[prev in list] [next in list] [prev in thread] [next in thread] 

List:       stunnel-users
Subject:    [stunnel-users] public domain [PATCH] to stunnel v456 to clear SSL_OP_LEGACY_SERVER_CONNECT
From:       "Simner, John" <john.simner () unify ! com>
Date:       2014-06-25 13:34:31
Message-ID: 5B74BA474FDDA4418CCD02CA71FBCA8A44EEC8AC () MCHP03MSX ! global-ad ! net
[Download RAW message or body]

[Attachment #2 (multipart/related)]

[Attachment #4 (multipart/alternative)]


Dear Michal, Dear All,
Please find attached a patch to stunnel 4.56 to clear SSL_OP_LEGACY_SERVER_=
CONNECT.

There was a security requirement to ensure that the stunnel client could no=
t connect to unpatched servers.

I am aware from OpenSSL (https://www.openssl.org/docs/ssl/SSL_CTX_set_optio=
ns.html ) that this parameter is currently set by default and has to be man=
ually cleared by calling SSL_CTX_clear_options() or SSL_clear_options()if a=
n OpenSSL client applications wants to ensure they can not connect to unpat=
ched servers (and thus avoid any security issues).

The attached patch achieves this.

OpenSSL also state "As more servers become patched the option SSL_OP_LEGACY=
_SERVER_CONNECT will not be set by default in a future version of OpenSSL" =
so this patch is only required until OpenSSL change the default value.

Thanks..
John



[Unify: Harmonize your enterprise]

John Simner BSc(Hons) MSc CEng. MIET
Software Engineer, Devices Development

Unify Enterprise Communications Ltd.

Tel.: +44 (1908) 817378 (One Number Service)
Email: john.simner@unify.com <mailto:vorname.name@unify.com>

www.unify.co.uk<http://www.unify.co.uk/>

Follow us: [Social_media_icons] <http://www.unify.com/social-media>

Unify Enterprise Communications Limited. Registered Office: Brickhill Stree=
t, Willen Lake, Milton Keynes, MK15 0DJ
Registered No: 5903714, England.

This email contains confidential information and is for the exclusive use o=
f the addressee.
If you are not the addressee then any distribution, copying, or use of this=
 email is prohibited.
If received in error, please advise the sender and delete immediately. We a=
ccept no liability for
any loss or damage suffered by any person arising from use of this email.



[Attachment #7 (text/html)]

<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
	{font-family:Tahoma;
	panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0cm;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:purple;
	text-decoration:underline;}
code
	{mso-style-priority:99;
	font-family:"Courier New";}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
	{mso-style-priority:99;
	mso-style-link:"Balloon Text Char";
	margin:0cm;
	margin-bottom:.0001pt;
	font-size:8.0pt;
	font-family:"Tahoma","sans-serif";}
span.EmailStyle17
	{mso-style-type:personal-compose;
	font-family:"Calibri","sans-serif";
	color:windowtext;}
span.BalloonTextChar
	{mso-style-name:"Balloon Text Char";
	mso-style-priority:99;
	mso-style-link:"Balloon Text";
	font-family:"Tahoma","sans-serif";}
.MsoChpDefault
	{mso-style-type:export-only;}
@page WordSection1
	{size:612.0pt 792.0pt;
	margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="2050" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Dear Michal, Dear All,<o:p></o:p></p>
<p class="MsoNormal">Please find attached a patch to stunnel 4.56 to clear \
SSL_OP_LEGACY_SERVER_CONNECT.<o:p></o:p></p> <p \
class="MsoNormal"><o:p>&nbsp;</o:p></p> <p class="MsoNormal">There was a security \
requirement to ensure that the stunnel client could not connect to unpatched \
servers.<o:p></o:p></p> <p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<p class="MsoNormal">I am aware from OpenSSL (<a \
href="https://www.openssl.org/docs/ssl/SSL_CTX_set_options.html">https://www.openssl.org/docs/ssl/SSL_CTX_set_options.html</a> \
) that this parameter is currently set by default and has to be manually cleared  by \
calling <code><span style="font-size:10.0pt">SSL_CTX_clear_options()</span></code> or \
<code><span style="font-size:10.0pt">SSL_clear_options()</span></code>if an OpenSSL \
client applications wants to ensure they can <strong><span \
style="font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;">not</span></strong> \
connect to unpatched servers (and thus avoid any security issues).<code><span \
style="font-size:10.0pt"><o:p></o:p></span></code></p> <p \
class="MsoNormal"><code><span \
style="font-size:10.0pt"><o:p>&nbsp;</o:p></span></code></p> <p class="MsoNormal">The \
attached patch achieves this.<o:p></o:p></p> <p \
class="MsoNormal"><o:p>&nbsp;</o:p></p> <p class="MsoNormal">OpenSSL also state \
&#8220;As more servers become patched the option <strong><span \
style="font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;">SSL_OP_LEGACY_SERVER_CONNECT</span></strong> \
will <strong><span style="font-family:&quot;Calibri&quot;,&quot;sans-serif&quot;">not</span></strong> \
be set by default in a future version of OpenSSL&#8221; so this patch is only \
required until OpenSSL change the default value.<o:p></o:p></p> <p \
class="MsoNormal"><o:p>&nbsp;</o:p></p> <p class="MsoNormal">Thanks..<o:p></o:p></p>
<p class="MsoNormal">John<o:p></o:p></p>
<p class="MsoNormal"><code><span \
style="font-size:10.0pt"><o:p>&nbsp;</o:p></span></code></p> <p \
class="MsoNormal"><o:p>&nbsp;</o:p></p> <p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<p class="MsoNormal"><span \
style="font-size:9.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:#2A3136"><img \
border="0" width="172" height="22" id="Picture_x0020_1" \
src="cid:image001.gif@01CF9081.B548ECF0" alt="Unify: Harmonize your \
enterprise"></span><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;"><o:p></o:p></span></p>
 <p class="MsoNormal"><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;"><o:p>&nbsp;</o:p></span></p>
 <p class="MsoNormal"><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;">John \
Simner BSc(Hons) MSc CEng. MIET</span><span \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;"><o:p></o:p></span></p>
 <p class="MsoNormal"><span \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;">Software \
Engineer, Devices Development<o:p></o:p></span></p> <p class="MsoNormal"><span \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;"><o:p>&nbsp;</o:p></span></p>
 <p class="MsoNormal"><span lang="FR" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;">Unify \
Enterprise Communications Ltd.<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-GB" style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;"><o:p>&nbsp;</o:p></span></p>
 <p class="MsoNormal"><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;">Tel.: \
&#43;44 (1908) 817378 (One Number Service)<o:p></o:p></span></p> <p \
class="MsoNormal"><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;">Email: \
<a href="mailto:vorname.name@unify.com"><span \
style="color:blue">john.simner@unify.com </span></a><u><span \
style="color:blue"><o:p></o:p></span></u></span></p> <p class="MsoNormal"><u><span \
lang="EN-GB" style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:blue"><o:p><span \
style="text-decoration:none">&nbsp;</span></o:p></span></u></p> <p class="MsoNormal" \
style="text-autospace:none"><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;"><a \
href="http://www.unify.co.uk/"><span \
style="color:blue">www.unify.co.uk</span></a></span><span \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;"><o:p></o:p></span></p>
 <p class="MsoNormal" style="text-autospace:none"><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;"><o:p>&nbsp;</o:p></span></p>
 <p class="MsoNormal" style="text-autospace:none"><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;">Follow \
us:&nbsp;</span><a href="http://www.unify.com/social-media"><span \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:windowtext;text-decoration:none"><img \
border="0" width="132" height="14" id="Bild_x0020_1" \
src="cid:image002.png@01CF9081.B548ECF0" alt="Social_media_icons"></span></a><span \
lang="EN-GB" style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;">&nbsp;
 <o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:blue"><o:p>&nbsp;</o:p></span></p>
 <p class="MsoNormal"><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:black">Unify \
Enterprise Communications Limited. Registered&nbsp;Office:&nbsp;Brickhill Street, \
Willen Lake, Milton Keynes, MK15 0DJ<o:p></o:p></span></p> <p class="MsoNormal"><span \
lang="EN-GB" style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:black">Registered \
No: 5903714, England. <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:black">&nbsp;<o:p></o:p></span></p>
 <p class="MsoNormal"><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:black">This \
email contains confidential information and is for the exclusive use of the \
addressee. <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:black">If \
you are not the addressee then any distribution, copying, or use of this email is \
prohibited.<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-GB" \
style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;;color:black">If \
received in error, please advise the sender and delete immediately. We accept no \
liability for<br> any loss or damage suffered by any person arising from use of this \
email.</span><span style="font-size:10.0pt;font-family:&quot;Arial&quot;,&quot;sans-serif&quot;"><o:p></o:p></span></p>
 <p class="MsoNormal"><span lang="EN-GB"><o:p>&nbsp;</o:p></span></p>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
</div>
</body>
</html>


["image001.gif" (image/gif)]
["image002.png" (image/png)]
["noconnectunpatchedservers.patch" (application/octet-stream)]

--- stunnel-4.56/src/ctx.c	2013-03-19 16:27:09.000000000 +0000
+++ stunnel_patch-4.56/src/ctx.c	2014-06-24 15:49:46.000000000 +0100
@@ -146,6 +146,8 @@
         }
     s_log(LOG_DEBUG, "SSL options set: 0x%08lX",
         SSL_CTX_set_options(section->ctx, section->ssl_options));
+    s_log(LOG_DEBUG, "SSL options reset: 0x%08lX",
+        SSL_CTX_clear_options(section->ctx, SSL_OP_LEGACY_SERVER_CONNECT)); 
 #ifdef SSL_MODE_RELEASE_BUFFERS
     SSL_CTX_set_mode(section->ctx,
         SSL_MODE_ENABLE_PARTIAL_WRITE |


_______________________________________________
stunnel-users mailing list
stunnel-users@stunnel.org
https://www.stunnel.org/cgi-bin/mailman/listinfo/stunnel-users


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic