[prev in list] [next in list] [prev in thread] [next in thread] 

List:       struts-dev
Subject:    =?utf-8?q?=5BGitHub=5D_=5Bstruts=5D_lukaszlenart_commented_on_a_diff_in_pull?= =?utf-8?q?_request_=2
From:       lukaszlenart_(via_GitHub) <git () apache ! org>
Date:       2023-04-13 7:25:32
Message-ID: PR_kwDOAPMNSs5N44jh-0af6fda9-681f-4faf-aa3c-08752ea179e8 () gitbox ! apache ! org
[Download RAW message or body]


lukaszlenart commented on code in PR #680:
URL: https://github.com/apache/struts/pull/680#discussion_r1165112178


##########
core/src/main/java/com/opensymphony/xwork2/ActionContext.java:
##########
@@ -157,6 +129,15 @@ public static ActionContext of(Map<String, Object> context) {
         return new ActionContext(context);
     }
 
+    /**
+     * Creates a new ActionContext based on empty Map
+     *
+     * @return new ActionContext
+     */
+    public static ActionContext of() {

Review Comment:
   There is already `of(Map<String, Object> context)` so I stick to the same convention



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]