[prev in list] [next in list] [prev in thread] [next in thread]
List: struts-dev
Subject: RE: [Fwd: Re: Maven test run]
From: "Tim Chen" <tchen () tampabay ! rr ! com>
Date: 2003-11-28 21:32:51
[Download RAW message or body]
Patches have been submitted to bugzilla for both project.xml and
maven.xml.
I am able to build struts from a clean download now by using just:
> maven
Attached is a combined patch file.
Tim Chen
tchen@tampabay.rr.com
-----Original Message-----
From: Martin Cooper [mailto:martinc@apache.org]
Sent: Friday, November 28, 2003 3:30 PM
To: Struts Developers List
Subject: Re: [Fwd: Re: Maven test run]
On Fri, 28 Nov 2003, Ted Husted wrote:
> And, for extra credit, if anyone were interested in trying it, a
> Mavenized version of Martin's very cool "release" target would be very
> useful. It wraps up both the source and binary distributions in both
> .zip and .gz format, ready for upload. Something like this should
> probably be a Maven plugin, since its something all the Jakarta
> projects need to do.
The maven-dist plugin does this for regular Maven projects. I don't know
what it would take to get it to do the right thing for Struts, though,
since I'm not much of a Maven maven myself.
--
Martin Cooper
>
> -Ted.
>
> -------- Original Message --------
> Subject: Re: Maven test run
> Date: Fri, 28 Nov 2003 13:55:44 -0500
> From: Ted Husted <husted@apache.org>
> Reply-To: Struts Developers List <struts-dev@jakarta.apache.org>
> Organization: Apache Software Foundation - Jakarta Project
> To: Struts Developers List <struts-dev@jakarta.apache.org>
> References: <000001c3b5e0$c9951bc0$86e0200a@CHENGT>
>
> We are interested in fixing the Maven build. The tests seem to run
> under the conventional build, which would imply that the issue may be
> in the Maven setup.
>
> Along with the core, we would also need a strategy for building the
> various example web applications. I'm thinking we may need a master
> webapps-projects.xml that each application artifact could extend.
>
> -Ted.
>
> Tim Chen wrote:
> > I submitted a patch recently for the maven build.
> > Sorry I didn't get a chance to (aka.. Just been lazy) attach it to a
> > formal bugzilla report as Rob had suggested that I do. The maven
> > test currently fail because the resources are not provided (look at
> > my past post for reference). Unfortunately, even after including the
> > source there are still test failures. I posted a sniplet of one of
> > the errors before. I never bothered to find out if those test
> > failures were due to the maven build or because of incorrectly
> > written tests. Either way, I'll try to find some time to fix the
> > maven build if anyone is interested.
> >
> > Tim Chen
> > tchen@tampabay.rr.com
> >
> >
> > -----Original Message-----
> > From: Ted Husted [mailto:husted@apache.org]
> > Sent: Friday, November 28, 2003 8:50 AM
> > To: Struts Developers List
> > Subject: Re: Maven test run
> >
> >
> > Steve Raeburn wrote:
> >
> >>There were no tests found because the test section was commented
> >>out! (and the example include pattern doesn't match our naming
> >>convention).
> >
> >
> >>I've enabled the JUnit tests. Using Cactus with Maven is beyond me,
> >>for now :-)
> >
> >
> > Mea culpa on the comment block. I did that to see if I could get the
> > rest of it to run, and then committed it accidentally. <head-slap/>
> >
> >
> >>When Maven runs the tests, TestModuleConfig is throwing a
> >>NullPointerException that doesn't show up when running from Ant. I'm
> >>inclined to believe that the Maven configuration requires more work
> >>rather that it actually being a problem with ModuleConfig.
> >
> > >
> >
> >>The Maven build remains HIGHLY experimental!!
> >
> >
> > I wonder if we could try a compromise? Could we have a Maven build
> > that just downloaded the dependencies into the central repository,
> > and a build.properties that got everything from there. This would
> > save us from
> >
> > going back to a "struts-library" distribution.
> >
> > I also wonder if it be possible to wrap our existing Ant build as
> > Maven goals? The user guide says that any Ant task can be used in
> > the maven.xml.
> >
> > http://maven.apache.org/reference/user-guide.html#Sample%20maven.xml
> >
> > Another stepping-stone might be to provide Maven projects for the
> > examples applications, especially the blank application. I'm
> > thinking the cannonical approach here would be to have a master
> > webapp-project.xml that we then extended for each application
> > "artifact".
> >
> > http://maven.apache.org/reference/user-guide.html#POM%20Inheritance
> >
> > I'm working on a changelog system now but will come back to this
> > later, if no one beats me to it. [Please do, if you can :)]
> >
> > -Ted.
> >
> >
> >
> > --------------------------------------------------------------------
> > -
> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
> >
> > --------------------------------------------------------------------
> > -
> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
> >
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
["StrutsMavenPatch.txt" (text/plain)]
Index: project.xml
===================================================================
RCS file: /home/cvspublic/jakarta-struts/project.xml,v
retrieving revision 1.12
diff -u -r1.12 project.xml
--- project.xml 28 Nov 2003 09:07:13 -0000 1.12
+++ project.xml 28 Nov 2003 21:31:36 -0000
@@ -308,6 +308,22 @@
<include>org/apache/struts/config/TestActionConfigMatcher.java</include>
<include>org/apache/struts/util/Test*.java</include>
</includes>
+ <resources>
+ <resource>
+ <directory>${basedir}/conf/share</directory>
+ <targetPath>org/apache/struts/resources</targetPath>
+ <includes>
+ <include>**/*.xml</include>
+ <include>**/*.dtd</include>
+ </includes>
+ </resource>
+ <resource>
+ <directory>${basedir}/src/test</directory>
+ <includes>
+ <include>**/*.xml</include>
+ </includes>
+ </resource>
+ </resources>
</unitTest>
<!-- J A R R E S O U R C E S -->
Index: maven.xml
===================================================================
RCS file: /home/cvspublic/jakarta-struts/maven.xml,v
retrieving revision 1.2
diff -u -r1.2 maven.xml
--- maven.xml 21 Nov 2003 06:22:09 -0000 1.2
+++ maven.xml 28 Nov 2003 21:31:42 -0000
@@ -1,8 +1,51 @@
-<project default="jar:jar">
+<project default="dist"
+ xmlns:j="jelly:core"
+ xmlns:ant="jelly:ant">
<preGoal name="xdoc:jelly-transform">
<attainGoal name="html2xdoc"/>
</preGoal>
+ <postGoal name="dist:prepare-bin-filesystem">
+ <!-- Copy Instructions and Readmes -->
+ <ant:copy todir="${maven.dist.bin.assembly.dir}">
+ <ant:fileset dir=".">
+ <ant:include name="README*"/>
+ <ant:include name="LICENSE*"/>
+ <ant:include name="STATUS*"/>
+ <ant:include name="INSTALL*"/>
+ </ant:fileset>
+ </ant:copy>
+
+ <!-- Copy configuration files -->
+ <j:set var="docsDest" value="${maven.docs.dest}"/>
+ <ant:copy todir="${maven.dist.bin.assembly.dir}/conf">
+ <ant:fileset dir="./conf/share">
+ <ant:include name="*.xml"/>
+ <ant:include name="*.dtd"/>
+ </ant:fileset>
+ </ant:copy>
+ </postGoal>
+
+ <postGoal name="dist:prepare-src-filesystem">
+ <!-- Copy Instructions and Readmes -->
+ <ant:copy todir="${maven.dist.src.assembly.dir}">
+ <ant:fileset dir=".">
+ <ant:include name="README*"/>
+ <ant:include name="LICENSE*"/>
+ <ant:include name="STATUS*"/>
+ <ant:include name="INSTALL*"/>
+ </ant:fileset>
+ </ant:copy>
+
+ <!-- Copy configuration files -->
+ <j:set var="docsDest" value="${maven.docs.dest}"/>
+ <ant:copy todir="${maven.dist.src.assembly.dir}/conf">
+ <ant:fileset dir="./conf/share">
+ <ant:include name="*.xml"/>
+ <ant:include name="*.dtd"/>
+ </ant:fileset>
+ </ant:copy>
+ </postGoal>
</project>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic