[prev in list] [next in list] [prev in thread] [next in thread] 

List:       strongswan-users
Subject:    Re: [strongSwan] [strongswan] davici: Fix codesonar warnings
From:       Martin Willi <martin () strongswan ! org>
Date:       2020-06-15 15:55:33
Message-ID: f88de0b21cb8cb6bb015a6338f2843d69a7cc4af.camel () strongswan ! org
[Download RAW message or body]

Hi,

> Fixed below codesonar warning.
> isprint() is invoked here with an argument of signed type char, but
> only has defined behavior for int arguments that are either
> representable as unsigned char or equal to the value of macro EOF(-
> 1).
> 
> To avoid this unexpected behaviour, typecasted char type argument to
> unsigned char type.

Thanks for the patch, applied with some minor changes to master.

Your submission is a patch for your build environment, creating a patch
to davici. Please create patches against the davici git tree for future
submissions, preferably using git format-patch/send-email.

Regards
Martin

[prev in list] [next in list] [prev in thread] [next in thread]