[prev in list] [next in list] [prev in thread] [next in thread] 

List:       strongswan-announce
Subject:    Re: [strongSwan-dev] [PATCH] Remove duplicate code
From:       Martin Willi <martin () strongswan ! org>
Date:       2011-11-21 9:29:41
Message-ID: 1321867781.2452.4.camel () martin
[Download RAW message or body]

Hi Thomas,

> --- a/src/libcharon/encoding/payloads/sa_payload.c
> +++ b/src/libcharon/encoding/payloads/sa_payload.c
> @@ -122,12 +122,6 @@ METHOD(payload_t, verify, status_t,
>  				break;
>  			}
>  		}
> -		else if (current_number < expected_number)
> -		{
> -			DBG1(DBG_ENC, "proposal number smaller than previous");
> -			status = FAILED;
> -			break;
> -		}

Even when removing the dead code, this proposal numbering check does not
make a lot of sense. I've change the code [1] to reject the payload only
when it has decreasing numbers; everything else should be ok.

Thanks!
Martin

[1]http://git.strongswan.org/?p=strongswan.git;a=commitdiff;h=b2e493ab



_______________________________________________
Dev mailing list
Dev@lists.strongswan.org
https://lists.strongswan.org/mailman/listinfo/dev
[prev in list] [next in list] [prev in thread] [next in thread]