[prev in list] [next in list] [prev in thread] [next in thread] 

List:       strongswan-announce
Subject:    Re: [strongSwan-dev] [PATCH] DiffieHellman Groups 22-24 in RFC5114
From:       Martin Willi <martin () strongswan ! org>
Date:       2010-04-19 12:50:36
Message-ID: 1271681436.1483.24.camel () martin
[Download RAW message or body]

Hi Joy,

> +       lib->crypto->add_dh(lib->crypto, MODP_1024_160,
> +       lib->crypto->add_dh(lib->crypto, MODP_2048_224,
> +       lib->crypto->add_dh(lib->crypto, MODP_2048_256,
>         lib->crypto->add_dh(lib->crypto, MODP_2048_BIT,
>         lib->crypto->add_dh(lib->crypto, MODP_1536_BIT, 

I slightly changed the group registration order, as the first registered
group is used by default. MODP_1024_160 probably not the ideal candidate
for the default group.

Otherwise the patch looks fine, applied to master. I additionally
registered the new groups in the gcrypt and openssl plugins.

Many thanks to your contribution.

Best regards
Martin


_______________________________________________
Dev mailing list
Dev@lists.strongswan.org
https://lists.strongswan.org/mailman/listinfo/dev
[prev in list] [next in list] [prev in thread] [next in thread]