[prev in list] [next in list] [prev in thread] [next in thread] 

List:       stringtemplate-interest
Subject:    Re: [stringtemplate-interest] bug in
From:       Terence Parr <parrt () cs ! usfca ! edu>
Date:       2008-03-25 22:14:50
Message-ID: 6D8C4E13-8D67-4CCB-96F7-2D85513DFD12 () cs ! usfca ! edu
[Download RAW message or body]

thanks...added bug:

http://www.antlr.org:8888/browse/ST-37

Ter
On Mar 25, 2008, at 4:05 AM, Harry wrote:
> Hi,
>
> I spotted a little bug in the method
>
> org.antlr.stringtemplate.StringTemplate.removeAttribute(String)
>
> when "attributes" is null, a NullPointerException is called. In  
> other places of
> the code
> a check is made to verify if "attributes" is null or not. In my  
> opinion, when
> "attributes"
> is null, nothing should occur, so I would write :
>
>  if (attributes != null) attributes.remove(name);
>
> instead of
>
>  attributes.remove(name);
>
> Best regards,
>
>                                                       Harry Karadimas
> ______________________________________________________________________
> Dr Harry Karadimas  Medecin Ingenieur
> resp. Recherche et Developpement, Administration Wintel
> Departement d'Information Hospitalier (DIH)
> C.H.U. Albert Chenevier - Henri Mondor
> 51, av. du Marechal de Lattre de Tassigny               94010  CRETEIL
> tel : (00 33 1) 49 81 21 79                fax : (00 33 1) 49 81 27 08
> secr.: (00 33 1) 49 81 23 82         m.el.:harry.karadimas@hmn.aphp.fr
>
>
> _______________________________________________
> stringtemplate-interest mailing list
> stringtemplate-interest@antlr.org
> http://www.antlr.org:8080/mailman/listinfo/stringtemplate-interest

_______________________________________________
stringtemplate-interest mailing list
stringtemplate-interest@antlr.org
http://www.antlr.org:8080/mailman/listinfo/stringtemplate-interest
[prev in list] [next in list] [prev in thread] [next in thread]