[prev in list] [next in list] [prev in thread] [next in thread] 

List:       strace
Subject:    Re: GSoC 2017 Introduction: Netlink socket parsers
From:       JingPiao Chen <chenjingpiao () gmail ! com>
Date:       2017-04-18 11:07:17
Message-ID: CA+AqBCF4=LsrWhF=6Ovp5T6q=_S0MKpPoyJbHHPXjjxiZ7hEXQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Mon, Apr 17, 2017 at 9:40 PM, Dmitry V. Levin wrote:
>On Wed, Mar 29, 2017 at 05:39:59PM +0800, JingPiao Chen wrote:
>> I updated the patch[1] and the proposal draft[2].
>> Please provide some feedback.
>> [1]https://github.com/ppiao/strace/tree/nl-socket
>
>As I said, every logically separate change must go to an individual commit,
>the way Fabien did in his branch.  You can rebase/fix/whatever commits
>made by Fabien, but please don't squash them -- nobody is going to spend
>time on a squashed netlink branch.
>
>I've just pushed several netlink related commits to master, you can review
>them and use as examples of commit separation, too.

Thank you for your reply. I have read the code.

>Note that at least some of commits in netlink branch contain bugs,
>including design bugs.  For example, the first commit "Add support for
>NLMSG_ERROR and NLMSG_DONE" stops netlink processing when NLMSG_ERROR
>or NLMSG_DONE is encountered, which is incorrect.
--
JingPiao Chen

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><div class="gmail_extra">On Mon, Apr 17, 2017 \
at 9:40 PM, Dmitry V. Levin wrote:</div><div class="gmail_extra">&gt;On Wed, Mar 29, \
2017 at 05:39:59PM +0800, JingPiao Chen wrote:</div><div class="gmail_extra">&gt;&gt; \
I updated the patch[1] and the proposal draft[2].</div><div \
class="gmail_extra">&gt;&gt; Please provide some feedback.</div><div \
class="gmail_extra">&gt;&gt; [1]<a \
href="https://github.com/ppiao/strace/tree/nl-socket">https://github.com/ppiao/strace/tree/nl-socket</a></div><div \
class="gmail_extra">&gt;</div><div class="gmail_extra">&gt;As I said, every logically \
separate change must go to an individual commit,</div><div \
class="gmail_extra">&gt;the way Fabien did in his branch.   You can \
rebase/fix/whatever commits</div><div class="gmail_extra">&gt;made by Fabien, but \
please don&#39;t squash them -- nobody is going to spend</div><div \
class="gmail_extra">&gt;time on a squashed netlink branch.</div><div \
class="gmail_extra">&gt;</div><div class="gmail_extra">&gt;I&#39;ve just pushed \
several netlink related commits to master, you can review</div><div \
class="gmail_extra">&gt;them and use as examples of commit separation, too.</div><div \
class="gmail_extra"><br></div><div class="gmail_extra">Thank you for your reply. I \
have read the code.</div><div class="gmail_extra"><br></div><div \
class="gmail_extra">&gt;Note that at least some of commits in netlink branch contain \
bugs,</div><div class="gmail_extra">&gt;including design bugs.   For example, the \
first commit &quot;Add support for</div><div class="gmail_extra">&gt;NLMSG_ERROR and \
NLMSG_DONE&quot; stops netlink processing when NLMSG_ERROR</div><div \
class="gmail_extra">&gt;or NLMSG_DONE is encountered, which is incorrect.</div><div \
class="gmail_extra">--</div><div class="gmail_extra">JingPiao Chen</div></div></div>



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel


[prev in list] [next in list] [prev in thread] [next in thread]