[prev in list] [next in list] [prev in thread] [next in thread] 

List:       strace
Subject:    Re: [PATCH 06/11] fadvise: Change printing of len argument to unsigned in fadvise64 syscall
From:       "Dmitry V. Levin" <ldv () altlinux ! org>
Date:       2016-09-27 8:46:37
Message-ID: 20160927084637.GF5916 () altlinux ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thu, Sep 22, 2016 at 12:21:20AM +0300, Eugene Syromyatnikov wrote:
> long sys_fadvise64(int fd, loff_t offset, size_t len, int advice);

At the same time, the implementation does
SYSCALL_DEFINE4(fadvise64, int, fd, loff_t, offset, size_t, len, int, advice)
{
	return sys_fadvise64_64(fd, offset, len, advice);
}

This is an implicit cast from size_t to loff_t, so for all intents and
purposes (see e.g. the check for len < 0 inside sys_fadvise64_64) it's
the same loff_t type.  I don't think it worths the change.


-- 
ldv

[Attachment #5 (application/pgp-signature)]

------------------------------------------------------------------------------


_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel


[prev in list] [next in list] [prev in thread] [next in thread]