[prev in list] [next in list] [prev in thread] [next in thread] 

List:       strace
Subject:    Re: [PATCH v3] decode extend getsockopt/setsockopt options
From:       "Dmitry V. Levin" <ldv () altlinux ! org>
Date:       2015-08-26 21:23:58
Message-ID: 20150826212358.GA20313 () altlinux ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thu, Aug 20, 2015 at 09:22:08AM -0400, Mike Frysinger wrote:
> On 20 Aug 2015 14:42, Dmitry V. Levin wrote:
> > On Wed, Aug 19, 2015 at 01:29:27PM -0400, Mike Frysinger wrote:
> > > * util.c (printxval): Rename to ...
> > > (printxvals): ... this.  Rewrite to be varargs based.
> > 
> > OK, let's have two separate functions so that
> > the most frequent use case won't be penalized.
> 
> so i made a small file:
> main() { int i; for (i = 0; i < 1000000; ++i) arch_prctl(0, 0); }
> 
> then i ran it like so:
> $ time strace -o /dev/null ./a.out
> 
> i didn't observe significant diff in speed between two funcs and one varargs.
> the new version took 17.510s on average while the old one took 17.478s.  that's
> like 30ns per syscall.  i think we can live with that ;).

Thanks, pushed this edition of the patch.


-- 
ldv

[Attachment #5 (application/pgp-signature)]

------------------------------------------------------------------------------


_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel


[prev in list] [next in list] [prev in thread] [next in thread]