[prev in list] [next in list] [prev in thread] [next in thread] 

List:       strace
Subject:    Re: [PATCH] Add decoding of sockets descriptor 'paths' for network calls.
From:       Philippe Ombredanne <pombredanne () nexb ! com>
Date:       2014-02-02 20:31:48
Message-ID: CAOFm3uGk2PanHm_-hUvmZdzZB1gFaHWYgdzHnCt6GvDm0oVYAA () mail ! gmail ! com
[Download RAW message or body]

On Sun, Feb 2, 2014 at 6:04 PM, Dmitry V. Levin <ldv@altlinux.org> wrote:
> On Sat, Feb 01, 2014 at 09:57:45AM -0800, Philippe Ombredanne wrote:
>> @@ -353,7 +355,7 @@ pathtrace_match(struct tcb *tcp)
>>        * been handled is to just check arg[0].
>>        */
>>
>> -     if (s->sys_flags & TRACE_FILE)
>> +     if (s->sys_flags & (TRACE_FILE | TRACE_NETWORK))
>>               return upathmatch(tcp, tcp->u_arg[0]);
>>
>>       if (s->sys_flags & TRACE_DESC)
>
> This TRACE_NETWORK case had to go along with TRACE_DESC, not TRACE_FILE.
> Fixed.

bummer ... how stupid of me... thanks for catching it

>> diff --git a/tests/Makefile.am b/tests/Makefile.am
>> index d8262f0..20736e3 100644
>> --- a/tests/Makefile.am
>> +++ b/tests/Makefile.am
>> @@ -4,7 +4,7 @@ AM_CFLAGS = $(WARN_CFLAGS)
>>
>>  check_PROGRAMS = net-accept-connect set_ptracer_any sigaction
>>
>> -TESTS = ptrace_setoptions strace-f qual_syscall sigaction.sh stat net \
>> +TESTS = ptrace_setoptions strace-f qual_syscall sigaction.sh stat net net-fd \
>
> net-fd and net tests do not work well when run simultaneously.
> I've made adjustments to the test suite to handle it properly.
>
> Committed to master.  Thanks,

Thank you plus plus!

-- 
Philippe Ombredanne

------------------------------------------------------------------------------
WatchGuard Dimension instantly turns raw network data into actionable 
security intelligence. It gives you real-time visual feedback on key
security issues and trends.  Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel
[prev in list] [next in list] [prev in thread] [next in thread]