[prev in list] [next in list] [prev in thread] [next in thread] 

List:       strace
Subject:    Re: [PATCH] fix off_t/rlim_t size checks when cross-compiling
From:       "Dmitry V. Levin" <ldv () altlinux ! org>
Date:       2010-09-13 20:14:17
Message-ID: 20100913201417.GB32312 () altlinux ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sun, Sep 12, 2010 at 04:01:47AM -0400, Mike Frysinger wrote:
> The current off_t/rlim_t size checks (wrt size of long long) use AC_RUN
> which obviously doesn't work when cross-compiling.  While we don't hit any
> configure errors, the fall back code is pretty dumb (which is to say there
> isn't any).  Considering the code in question though, we can use some fun
> compiler tricks with sizeof and array lengths to turn it into a pure build
> test and avoid the RUN issue completely.

All these four changes look OK for me.


--=20
ldv

[Attachment #5 (application/pgp-signature)]

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing
http://p.sf.net/sfu/novell-sfdev2dev


_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel


[prev in list] [next in list] [prev in thread] [next in thread]