[prev in list] [next in list] [prev in thread] [next in thread] 

List:       strace
Subject:    Re: [PATCH] syscallent.h
From:       Mike Frysinger <vapier () gentoo ! org>
Date:       2009-11-13 16:28:58
Message-ID: 200911131128.59364.vapier () gentoo ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 13 November 2009 10:51:37 Dmitry V. Levin wrote:
> On Sat, Nov 07, 2009 at 09:21:11AM -0500, Mike Frysinger wrote:
> > On Saturday 07 November 2009 08:13:42 Dmitry V. Levin wrote:
> > > Yes, linux/syscallent.h is used on x86.  Also, this file is included by
> > > linux/x86_64/syscallent1.h and linux/ia64/syscallent.h files.
> >
> > so basically there's x86-specific files stuck in common code location ?
> 
> Yes, it could be said so.
> 
> > wouldnt it make sense to move those to an x86/ subdir then ?
> 
> To linux/i386/ then.  That would be quite a big move:
> 
> linux/x86_64/syscallent1.h:#include "../syscallent.h"
> linux/x86_64/ioctlent1.h:#include "../ioctlent.h"
> linux/x86_64/errnoent1.h:#include "../errnoent.h"
> linux/x86_64/signalent1.h:#include "../signalent.h"
> linux/ia64/syscallent.h:#include "../syscallent.h"
> linux/ia64/syscallent.h:#include "../dummy.h"
> linux/arm/ioctlent1.h:#include "../ioctlent.h"
> linux/arm/errnoent1.h:#include "../errnoent.h"
> linux/arm/signalent1.h:#include "../signalent.h"

i only said 'syscallent.h' on purpose.  the errno/signal list is largely 
common as most ports use that.  the ioctl list could under go work to unify 
it, but that would be a large endeavor.

all in all, relocating syscallent.h should be trivial
-mike

["signature.asc" (application/pgp-signature)]

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel


[prev in list] [next in list] [prev in thread] [next in thread]