[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sssd-devel
Subject:    =?utf-8?b?W1NTU0Rd?= [sssd PR#719][comment] ifp: extraAttributes is UnknownProperty
From:       jhrozek <sssd-github-notification () fedorahosted ! org>
Date:       2018-12-18 20:08:12
Message-ID: gh-SSSD/sssd-719-2018-49903e49-28a3-4b69-a4af-abc5f315a587 () sssd-github-notification ! fedorahosted ! org
[Download RAW message or body]

[Attachment #2 (unknown)]

  URL: https://github.com/SSSD/sssd/pull/719
Title: #719: ifp: extraAttributes is UnknownProperty

jhrozek commented:
"""
Can you also amend the ifp-test unit test?
```
./ifp_tests
[==========] Running 4 test(s).
[ RUN      ] test_el_to_dict
[       OK ] test_el_to_dict
[ RUN      ] test_attr_acl
[  ERROR   ] --- s2[i]
[   LINE   ] --- /home/jhrozek/devel/sssd/src/tests/cmocka/test_ifp.c:117: error: Failure!
[  FAILED  ] test_attr_acl
[ RUN      ] test_attr_acl_ex
[       OK ] test_attr_acl_ex
[ RUN      ] test_attr_allowed
[       OK ] test_attr_allowed
[==========] 4 test(s) run.
[  PASSED  ] 3 test(s).
[  FAILED  ] 1 test(s), listed below:
[  FAILED  ] test_attr_acl

 1 FAILED TEST(S)
```

I think the extraAttributes piece should be just added to the list..
"""

See the full comment at https://github.com/SSSD/sssd/pull/719#issuecomment-448352926

[Attachment #3 (text/plain)]

_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-leave@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org


[prev in list] [next in list] [prev in thread] [next in thread]