[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sssd-devel
Subject:    Re: [SSSD] [PATCH] Two sbus fixes
From:       Pavel Březina <pbrezina () redhat ! com>
Date:       2015-08-26 12:26:06
Message-ID: 55DDB05E.7040007 () redhat ! com
[Download RAW message or body]

On 08/10/2015 03:31 PM, Jakub Hrozek wrote:
> Hi,
>
> I found two issues in the sbus code while testing the by-certificate
> lookups. One was that if parsing the reply with client UID failed, then
> errno would have been garbage.
>
> The second is that since we added signal handling, we always receive
> NameOwnerChanged after someone binds to the bus. But NameOwnerChanged
> sender is the bus itself, which doesn't reveal the sender ID -- the
> request to find the sender ID failed and we didn't process the signal at
> all.
>
> The only related discussion I found was:
>      http://permalink.gmane.org/gmane.comp.freedesktop.dbus/7404
> which would indicate that for the bus itself, the UID can't be
> retrieved. So I modified the request that reads the UID to return a
> special error in this case and lets the caller handle it -- for signals,
> we proceed, but for messages, we don't because we can't check the UID
> against the ACL.

Makes sense.

Ack, but it needs to be rebased.

_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[prev in list] [next in list] [prev in thread] [next in thread]