[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sssd-devel
Subject:    Re: [SSSD] [PATCH] pysss: Fix double free
From:       Jakub Hrozek <jhrozek () redhat ! com>
Date:       2015-01-30 11:51:30
Message-ID: 20150130115130.GH3114 () hendrix ! brq ! redhat ! com
[Download RAW message or body]

On Fri, Jan 30, 2015 at 12:39:18PM +0100, Jakub Hrozek wrote:
> On Thu, Jan 29, 2015 at 03:34:37PM +0100, Pavel Reichl wrote:
> > 
> > On 01/29/2015 11:51 AM, Lukas Slebodnik wrote:
> > >On (29/01/15 10:27), Pavel Reichl wrote:
> > >>On 01/29/2015 08:16 AM, Lukas Slebodnik wrote:
> > >>>ehlo,
> > >>>
> > >>>the patch for ticket "functions with reference leaks within sssd"
> > >>>#1195 was not tested proerly and double free was introduced.
> > >>>
> > >>>Simple patch is attached.
> > >>>
> > >>>LS
> > >>>
> > >>Thank you for the patch and I'm sorry for missing that. Patch looks good to
> > >>me.
> > >>
> > >>Running without the patch 'python python-test.py' yields 'Aborted (core
> > >>dumped)' and valgrind finds errors (ERROR SUMMARY: 2 errors from 2 contexts)
> > >>
> > >>After applying the patch no core dump is happening and valgrind finds 0
> > >>errors.
> > >>
> > >>ACK
> > >Thank you for review.
> > >
> > >Could you attach link to CI results?
> > >I prefer reviewer attach links.
> > >
> > >LS
> > >_______________________________________________
> > >sssd-devel mailing list
> > >sssd-devel@lists.fedorahosted.org
> > >https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> > Congratulations Lukas it's a boy....oh, I mean success.
> > 
> > http://sssd-ci.duckdns.org/logs/job/7/01/summary.html
> 
> * master: 3cd7275c3c41a03eb65769c2bf4e472d1de7b8c0

Also sssd-1-12: 8e0766215aef902eec24d880fbf2b30686c452e6
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[prev in list] [next in list] [prev in thread] [next in thread]