[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sssd-devel
Subject:    Re: [SSSD] [PATCH] Change order of libraries in linking process.
From:       Lukas Slebodnik <lslebodn () redhat ! com>
Date:       2013-07-22 11:40:01
Message-ID: 20130722114001.GC5313 () mail ! corp ! redhat ! com
[Download RAW message or body]

On (12/06/13 14:59), Jakub Hrozek wrote:
> On Wed, Jun 12, 2013 at 02:52:08PM +0300, Timo Aaltonen wrote:
> > On 12.06.2013 14:39, Lukas Slebodnik wrote:
> > > ehlo,
> > > 
> > > It seems that some linkers have problem with wrong order of libraries.
> > > This commit only change order.
> > > 
> > > Attached patch should fix next issue:
> > > Library libsss_crypt.so is used in linking process, but there are
> > > undefined references.
> > > 
> > > It seems that I changed order of libraries after rewriting link_all_deplibs
> > > patch to use automake variable SSSD_INTERNAL_LTLIBS. I only tested
> > > new patch with patched version of libtool on fedora.
> > > 
> > > libtool: link: gcc -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith \
> > > -Wcast-qual -Wcast-align -Wwrite-strings -Werror-implicit-function-declaration \
> > > -fno-strict-aliasing -std=gnu99 -g -O2 -fstack-protector \
> > > --param=ssp-buffer-size=4 -Wformat -Werror=format-security \
> > > -I/usr/include/samba-4.0 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE \
> > > -D_LARGEFILE64_SOURCE -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -o \
> > > .libs/sss_ssh_authorizedkeys src/sss_client/sss_ssh_authorizedkeys-common.o \
> > > src/sss_client/ssh/sss_ssh_authorizedkeys-sss_ssh_client.o \
> > > src/sss_client/ssh/sss_ssh_authorizedkeys-sss_ssh_authorizedkeys.o  -lpthread \
> > > -ltalloc /usr/lib/x86_64-linux-gnu/libpopt.so ./.libs/libsss_crypt.so \
> > > ./.libs/libsss_debug.so ./.libs/libsss_child.so ./.libs/libsss_util.so \
> > >                 -Wl,-rpath -Wl,/usr/lib/x86_64-linux-gnu/sssd
> > > ./.libs/libsss_util.so: undefined reference to `sss_base64_decode'
> > > ./.libs/libsss_util.so: undefined reference to `s3crypt_gen_salt'
> > > ./.libs/libsss_util.so: undefined reference to `sss_base64_encode'
> > > ./.libs/libsss_util.so: undefined reference to `s3crypt_sha512'
> > > collect2: error: ld returned 1 exit status
> > 
> > ACK
> > 
> > fixed the build issue I had, thanks!
> 
> That's bizzare. But obviously works for Timo and still works in Fedora
> as well.
> 
> Ack++, pushed to master.

just for a record.
This issue was caused by linker flag "-Wl,--as-needed".

LS
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel


[prev in list] [next in list] [prev in thread] [next in thread]