[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sssd-devel
Subject:    Re: [SSSD] [PATCHES] Fix warnings
From:       Jakub Hrozek <jhrozek () redhat ! com>
Date:       2013-07-22 9:47:10
Message-ID: 20130722094710.GB18515 () hendrix ! brq ! redhat ! com
[Download RAW message or body]

On Mon, Jul 22, 2013 at 11:43:40AM +0200, Jakub Hrozek wrote:
> On Fri, Jul 19, 2013 at 03:36:22PM +0200, Lukas Slebodnik wrote:
> > On (19/07/13 10:29), Jakub Hrozek wrote:
> > >On Thu, Jul 18, 2013 at 01:09:11PM +0200, Lukas Slebodnik wrote:
> > >> ehlo,
> > >> 
> > >> I tested some patches with old distro and I spotted warnings.
> > >>     -- uninitialized variable (gcc 4.4.7)
> > >>     -- macro AM_PROG_AR not found in library (automake 1.11.1)
> > >> 
> > >> I checked them and all warnings should be harmless, but anyway we don't like
> > >> warnings.
> > >> 
> > >> Two patches are attached.
> > >> 
> > >> LS
> > >
> > >Patch #1 really needs to be split into two, the Makefile.am/sssd.spec.in
> > >is a separate issue.
> > I removed changes to files Makefile.am/sssd.spec.in.
> > (I use those changes only internally.)
> > 
> > >
> > >Patch #2 looks OK to me, is the automake version you tested with (1.11.1)
> > >the one shipped on RHEL5?
> > RHEL6, master can not be built on RHEL5.
> > 
> > Updated patches are attached
> > 
> > LS
> 
> [PATCH 1/2] Fix warnings: uninitialized variable
> Ack after all. I checked all the functions you touched and I think GCC
> is simply wrong. However, setting the variables is OK and doesn't change
> the flow in any way.
> 
> [PATCH 2/2] Fix autotols warnings: macro xyz not found in library
> Ack, builds fine on Fedora and RHEL6.

Pushed to master.
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[prev in list] [next in list] [prev in thread] [next in thread]