[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sssd-devel
Subject:    [PATCH 04/18] SSS_DEBUGLEVEL: silence analyzer warnings
From:       jhrozek () redhat ! com (Jakub Hrozek)
Date:       2012-04-25 14:45:06
Message-ID: mailman.12.1335441111.29027.sssd-devel () lists ! fedorahosted ! org
[Download RAW message or body]

Errno was returned instead of ret.

The other hunk removes return code from fread - it is not needed, the
NULL termination of the string is ensured by initializing the buffer.
---
 src/tools/sss_debuglevel.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/tools/sss_debuglevel.c b/src/tools/sss_debuglevel.c
index 83be144422eed47ef013b9d5bac837f10a6a9b6e..623cea2acd9677b5a6b954f71db981c64ed316e9 \
                100644
--- a/src/tools/sss_debuglevel.c
+++ b/src/tools/sss_debuglevel.c
@@ -218,7 +218,7 @@ errno_t send_sighup()
         ret = errno;
         DEBUG(SSSDBG_CRIT_FAILURE, ("Could not send SIGHUP to process %d: %s\n",
               pid, strerror(errno)));
-        return errno;
+        return ret;
     }
 
     return EOK;
@@ -333,7 +333,7 @@ errno_t get_sssd_pid(pid_t *out_pid)
         goto done;
     }
 
-    ret = fread(pid_str, sizeof(char), MAX_PID_LENGTH * sizeof(char), pid_file);
+    fread(pid_str, sizeof(char), MAX_PID_LENGTH * sizeof(char), pid_file);
     if (!feof(pid_file)) {
         /* eof not reached */
         ret = ferror(pid_file);
-- 
1.7.7.6


--BOKacYhQ+x31HxR3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; \
filename="0005-SSH-return-NULL-on-error-in-ssh_host_pubkeys_format_.patch"


[prev in list] [next in list] [prev in thread] [next in thread]