[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sr-users
Subject:    Re: [SR-Users] Is "new_conn_alias_flags" supported/recommended? It seems to solve my NAT problem, bu
From:       Cody Herzog <codyherzog () gmail ! com>
Date:       2016-01-28 1:41:48
Message-ID: CADtL+eP6YPudEyMbVqvSY6CgC5mzTp4jCoGyhYdHTAZ8DLUrBQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hello.

I've done some local testing of my changes to 'cfg.lex' and 'cfg.y'. The
changes are pretty small. I just added a few lines so that
'tcp_new_conn_alias_flags' can be parsed as global option in the config
file.

How would you recommend that I proceed?

Should I submit to the master branch and then make a pull request relative
to the 4.3 branch?

Or perhaps I should submit to a private developer branch first, then make a
pull request relative to the master branch.

I read the appropriate Wiki pages, but since this will be my first time
submitting, I want to be sure I do it properly.

Thanks.

On Fri, Jan 22, 2016 at 12:39 AM, Daniel-Constantin Mierla <
miconda@gmail.com> wrote:

> OK, thanks for reporting. When I get some time I will look to see if
> initializing all those options via config file can be added in a easy mode.
>
> If you want to add dedicated global parameter for it, do a pull request on
> gihub project.
>
> Cheers,
> Daniel
>
> On 22/01/16 02:40, Cody Herzog wrote:
>
> Thanks for the ongoing support.
>
> I tried 'tcp.new_conn_alias_flags = 1' in the global config section, but
> that causes a config file parse error on startup.
>
> I have also tried the following:
>
> 'tcp_new_conn_alias_flags = 1' <== parse error
>
> 'tcp_options.new_conn_alias_flags=1' <== NO parse error, but doesn't seem
> to change the option.
>
> The only way I've found to change the option is at runtime as follows:
>
> sudo kamctl kamcmd cfg.set_now_int tcp new_conn_alias_flags 1
>
>
> Thanks.
>
> On Tue, Jan 19, 2016 at 2:48 PM, Daniel-Constantin Mierla <
> <miconda@gmail.com>miconda@gmail.com> wrote:
>
>> Hello,
>>
>> I am not the developer that added the new_conn_alias_flags and had not
>> time to dig much in the code to given an precise answer. But if it make the
>> case you detailed to work, then set it. In its definition in the code i saw
>> it can be 0, 1 or 2.
>>
>> Try to see if it works to set it in kamailio.cfg with:
>>
>> tcp.new_conn_alias_flags = 1
>>
>> Use it in the part with global parameters.
>>
>> Cheers,
>> Daniel
>>
>>
>>
> --
> Daniel-Constantin Mierlahttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
> Book: SIP Routing With Kamailio - http://www.asipto.comhttp://miconda.eu
>
>

[Attachment #5 (text/html)]

<div dir="ltr"><div><div><div><div><div><div>Hello.<br><br></div>I&#39;ve done some \
local testing of my changes to &#39;cfg.lex&#39; and &#39;cfg.y&#39;. The changes are \
pretty small. I just added a few lines so that &#39;tcp_new_conn_alias_flags&#39; can \
be parsed as global option in the config file.<br><br></div>How would you recommend \
that I proceed?<br><br></div>Should I submit to the master branch and then make a \
pull request relative to the 4.3 branch?<br><br></div>Or perhaps I should submit to a \
private developer branch first, then make a pull request relative to the master \
branch.<br><br></div>I read the appropriate Wiki pages, but since this will be my \
first time submitting, I want to be sure I do it \
properly.<br><br></div><div>Thanks.<br></div></div><div class="gmail_extra"><br><div \
class="gmail_quote">On Fri, Jan 22, 2016 at 12:39 AM, Daniel-Constantin Mierla <span \
dir="ltr">&lt;<a href="mailto:miconda@gmail.com" \
target="_blank">miconda@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    OK, thanks for reporting. When I get some time I will look to see if
    initializing all those options via config file can be added in a
    easy mode.<br>
    <br>
    If you want to add dedicated global parameter for it, do a pull
    request on gihub project.<br>
    <br>
    Cheers,<br>
    Daniel<span class=""><br>
    <br>
    <div>On 22/01/16 02:40, Cody Herzog wrote:<br>
    </div>
    <blockquote type="cite">
      <div dir="ltr">
        <div>
          <div>
            <div>Thanks for the ongoing support.<br>
              <br>
            </div>
            I tried &#39;tcp.new_conn_alias_flags = 1&#39; in the global config
            section, but that causes a config file parse error on
            startup.<br>
            <br>
          </div>
          I have also tried the following:<br>
          <br>
          &#39;tcp_new_conn_alias_flags = 1&#39; &lt;== parse error<br>
          <br>
          &#39;tcp_options.new_conn_alias_flags=1&#39; &lt;== NO parse error,
          but doesn&#39;t seem to change the option.<br>
          <br>
        </div>
        The only way I&#39;ve found to change the option is at runtime as
        follows:<br>
        <br>
        sudo kamctl kamcmd cfg.set_now_int tcp new_conn_alias_flags 1<br>
        <div>
          <div><br>
            <br>
          </div>
          <div>Thanks.<br>
          </div>
        </div>
      </div>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On Tue, Jan 19, 2016 at 2:48 PM,
          Daniel-Constantin Mierla <span dir="ltr">&lt;<a \
href="mailto:miconda@gmail.com" target="_blank"></a><a \
href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>&gt;</span> \
                wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">  <div bgcolor="#FFFFFF" text="#000000"> Hello,<br>
              <br>
              I am not the developer that added the new_conn_alias_flags
              and had not time to dig much in the code to given an
              precise answer. But if it make the case you detailed to
              work, then set it. In its definition in the code i saw it
              can be 0, 1 or 2.<br>
              <br>
              Try to see if it works to set it in kamailio.cfg with:<br>
              <br>
              tcp.new_conn_alias_flags = 1<br>
              <br>
              Use it in the part with global parameters.<br>
              <br>
              Cheers,<br>
              Daniel
              <div>
                <div><br>
                  <br>
                </div>
              </div>
            </div>
          </blockquote>
        </div>
      </div>
    </blockquote>
    <br>
    </span><span class=""><pre cols="72">-- 
Daniel-Constantin Mierla
<a href="http://twitter.com/#!/miconda" \
target="_blank">http://twitter.com/#!/miconda</a> - <a \
href="http://www.linkedin.com/in/miconda" \
                target="_blank">http://www.linkedin.com/in/miconda</a>
Book: SIP Routing With Kamailio - <a href="http://www.asipto.com" \
target="_blank">http://www.asipto.com</a> <a href="http://miconda.eu" \
target="_blank">http://miconda.eu</a></pre>  </span></div>

</blockquote></div><br></div>



_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic