[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sr-users
Subject:    Re: [SR-Users] Wrong index on expires column in pua module
From:       Daniel-Constantin Mierla <miconda () gmail ! com>
Date:       2012-08-24 20:46:38
Message-ID: 5037E82E.6050001 () gmail ! com
[Download RAW message or body]

Hello,

On 8/24/12 6:53 PM, Andreas Granig wrote:
> Hi guys,
>
> In the pua table, there is a unique key on the "expires" column, which
> seems wrong to me, because you'll sooner or later end up with different
> pua entries having the same expiry time, no?
>
> At least we ended up with messages like this in the logs, I think it's
> caused by pua_reginfo tests:
>
> ERROR: db_mysql [km_dbase.c:122]: driver error on query: Duplicate entry
> '1345474412' for key 'expires_idx'
> ERROR: <core> [db_query.c:210]: error while submitting query
> ERROR: pua [pua.c:1171]: while inserting in db table pua
>
> Any comments on that?
the unique constraint on expires is wrong, indeed. Perhaps a copy&paste 
mistake when adding the index on expires, which makes sense of db only 
mode to fetch/delete expired records. The index was added by Peter Dunkley.

You can go ahead and commit/backport.

Cheers,
Daniel

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio Advanced Training, Berlin, Nov 5-8, 2012 - http://asipto.com/u/kat


_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
[prev in list] [next in list] [prev in thread] [next in thread]