[prev in list] [next in list] [prev in thread] [next in thread]
List: sr-dev
Subject: [sr-dev] [kamailio/kamailio] dialog: set context iuid for CANCEL requests (PR #3096)
From: descartin <notifications () github ! com>
Date: 2022-04-28 12:47:43
Message-ID: kamailio/kamailio/pull/3096 () github ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
set context iuid for CANCEL requests to let isflagset function return the right value \
in case a dialog flag was previously set on the call
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes \
that apply --> <!-- All points should be verified, otherwise, read the \
CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of \
these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that \
apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Using kamailio 5.4 version, we have seen that dlg_isflagset is not detecting a dialog \
flag set in the request route for the initial INVITE, when a CANCEL request arrives.
We have applied this change to set the dialog context unique ide for this request. \
Since it's done on dlg_onreply, dlg_onroute and dlg_ontimeout functions. This \
way, dlg_get_by_iuid(&dctx->iuid) in the function ki_dlg_isflagset is not NULL \
and dialog flags are detected.
Is this change correct? Or can it generate any kind of issues?
thanks a lot and regards
David
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3096
-- Commit Summary --
* dialog: set context iuid for CANCEL requests to let isflagset function return the \
right value in case a dialog flag was previously set on the call
-- File Changes --
M src/modules/dialog/dlg_handlers.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3096.patch
https://github.com/kamailio/kamailio/pull/3096.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3096
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3096@github.com>
[Attachment #5 (text/html)]
<p dir="auto">set context iuid for CANCEL requests to let isflagset function return \
the right value in case a dialog flag was previously set on the call</p>
<h4 dir="auto">Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox"> Commit message has the format required by \
CONTRIBUTING guide</li> <li class="task-list-item"><input type="checkbox" id="" \
disabled="" class="task-list-item-checkbox"> Commits are split per component (core, \
individual modules, libs, utils, ...)</li> <li class="task-list-item"><input \
type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Each component has \
a single commit (if not, squash them into one commit)</li> <li \
class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox"> No commits to README files for modules (changes must \
be done to docbook files<br> in <code class="notranslate">doc/</code> subfolder, the \
README file is autogenerated)</li> </ul>
<h4 dir="auto">Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which \
fixes an issue)</li> <li class="task-list-item"><input type="checkbox" id="" \
disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which \
adds new functionality)</li> <li class="task-list-item"><input type="checkbox" id="" \
disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that \
would change existing functionality)</li> </ul>
<h4 dir="auto">Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox"> PR should be backported to stable branches</li> <li \
class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox" checked=""> Tested changes locally</li> <li \
class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open \
issue number)</li> </ul>
<h4 dir="auto">Description</h4>
<p dir="auto">Using kamailio 5.4 version, we have seen that dlg_isflagset is not \
detecting a dialog flag set in the request route for the initial INVITE, when a \
CANCEL request arrives.</p> <p dir="auto">We have applied this change to set the \
dialog context unique ide for this request. Since it's done on dlg_onreply, \
dlg_onroute and dlg_ontimeout functions. This way, \
dlg_get_by_iuid(&dctx->iuid) in the function ki_dlg_isflagset is not NULL and \
dialog flags are detected.</p> <p dir="auto">Is this change correct? Or can it \
generate any kind of issues?</p> <p dir="auto">thanks a lot and regards<br>
David</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/3096'>https://github.com/kamailio/kamailio/pull/3096</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/kamailio/kamailio/pull/3096/commits/53778cadb524cd671e0a56b04ade22f20ce77d04" \
class="commit-link">53778ca</a> dialog: set context iuid for CANCEL requests to let \
isflagset function return the right value in case a dialog flag was previously set on \
the call</li> </ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: \
inline-block">(<a href="https://github.com/kamailio/kamailio/pull/3096/files">1 file</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3096/files#diff-fcedab6dfa18efb \
d763d366721440cf3f26e20979cfca362e165d0a2f8ed98ec">src/modules/dialog/dlg_handlers.c</a>
(3)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/3096.patch'>https://github.com/kamailio/kamailio/pull/3096.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/3096.diff'>https://github.com/kamailio/kamailio/pull/3096.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br \
/>Reply to this email directly, <a \
href="https://github.com/kamailio/kamailio/pull/3096">view it on GitHub</a>, or <a \
href="https://github.com/notifications/unsubscribe-auth/ABO7UZPJTBRKL6VCVEIG7BTVHKCG7ANCNFSM5USJME7Q">unsubscribe</a>.<br \
/>You are receiving this because you are subscribed to this thread.<img \
src="https://github.com/notifications/beacon/ABO7UZP3RG5P2TXGRNIIO4DVHKCG7A5CNFSM5USJME72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4SFDSH7A.gif" \
height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: \
none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; \
max-width: 0; max-height: 0; mso-hide: all">Message ID: \
<span><kamailio/kamailio/pull/3096</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3096",
"url": "https://github.com/kamailio/kamailio/pull/3096",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic