[prev in list] [next in list] [prev in thread] [next in thread]
List: sr-dev
Subject: [sr-dev] [kamailio/kamailio] pua: update_version_puadb() use pres_id to select record (#2420)
From: Victor Seva <notifications () github ! com>
Date: 2020-07-31 14:15:49
Message-ID: kamailio/kamailio/pull/2420 () github ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #2414
#### Description
* only relevant when db_mode is PUA_DB_ONLY
* call_id/to_tag/from_tag values can be "", for instance with
DIALOG_PUBLISH.* records. Then **ALL** records get version
field update
* update_vesion_puadb() is called from send_publish() and pres->id
value is valid after a call to get_record_puadb()
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2420
-- Commit Summary --
* pua: update_version_puadb() use pres_id to select record
-- File Changes --
M src/modules/pua/pua_db.c (20)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2420.patch
https://github.com/kamailio/kamailio/pull/2420.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2420
[Attachment #5 (text/html)]
<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox" checked=""> Commit message has the format required by \
CONTRIBUTING guide</li> <li class="task-list-item"><input type="checkbox" id="" \
disabled="" class="task-list-item-checkbox" checked=""> Commits are split per \
component (core, individual modules, libs, utils, ...)</li> <li \
class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox" checked=""> Each component has a single commit (if \
not, squash them into one commit)</li> <li class="task-list-item"><input \
type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No \
commits to README files for modules (changes must be done to docbook files<br> in \
<code>doc/</code> subfolder, the README file is autogenerated)</li> </ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which \
fixes an issue)</li> <li class="task-list-item"><input type="checkbox" id="" \
disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which \
adds new functionality)</li> <li class="task-list-item"><input type="checkbox" id="" \
disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that \
would change existing functionality)</li> </ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox" checked=""> PR should be backported to stable \
branches</li> <li class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox" checked=""> Tested changes locally</li> <li \
class="task-list-item"><input type="checkbox" id="" disabled="" \
class="task-list-item-checkbox" checked=""> Related to issue <a class="issue-link \
js-issue-link" data-error-text="Failed to load title" data-id="667830669" \
data-permission-text="Title is private" \
data-url="https://github.com/kamailio/kamailio/issues/2414" \
data-hovercard-type="issue" \
data-hovercard-url="/kamailio/kamailio/issues/2414/hovercard" \
href="https://github.com/kamailio/kamailio/issues/2414">#2414</a></li> </ul>
<h4>Description</h4>
<ul>
<li>only relevant when db_mode is PUA_DB_ONLY</li>
<li>call_id/to_tag/from_tag values can be "", for instance with<br>
DIALOG_PUBLISH.* records. Then <strong>ALL</strong> records get version<br>
field update</li>
<li>update_vesion_puadb() is called from send_publish() and pres->id<br>
value is valid after a call to get_record_puadb()</li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/2420'>https://github.com/kamailio/kamailio/pull/2420</a></p>
<h4>Commit Summary</h4>
<ul>
<li>pua: update_version_puadb() use pres_id to select record</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2420/files#diff-167462c6594353f6bad98a1b123d12e8">src/modules/pua/pua_db.c</a>
(20)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/2420.patch'>https://github.com/kamailio/kamailio/pull/2420.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/2420.diff'>https://github.com/kamailio/kamailio/pull/2420.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You \
are receiving this because you are subscribed to this thread.<br />Reply to this \
email directly, <a href="https://github.com/kamailio/kamailio/pull/2420">view it on \
GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZITWQLHKMBG2UYRDHLR6LGZJANCNFSM4PQKPZUQ">unsubscribe</a>.<img \
src="https://github.com/notifications/beacon/ABO7UZOP45ZYBJQYYHLXVDLR6LGZJA5CNFSM4PQKPZU2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4J7NJI3Q.gif" \
height="1" width="1" alt="" /></p> <script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2420",
"url": "https://github.com/kamailio/kamailio/pull/2420",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic