[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sr-dev
Subject:    [sr-dev] git:5.0:a18cef3b: usrloc: fix usrloc slot lock in ul.dump rpc procedure
From:       Daniel-Constantin Mierla <miconda () gmail ! com>
Date:       2017-10-30 17:13:56
Message-ID: E1e9DdM-00012E-QC () www ! kamailio ! org
[Download RAW message or body]

Module: kamailio
Branch: 5.0
Commit: a18cef3bbcc80004d4e013cb7ce08c0b20d8fc8c
URL: https://github.com/kamailio/kamailio/commit/a18cef3bbcc80004d4e013cb7ce08c0b20d8fc8c

Author: Vitaliy Aleksandrov <vitalik.voip@gmail.com>
Committer: Daniel-Constantin Mierla <miconda@gmail.com>
Date: 2017-10-30T18:12:48+01:00

usrloc: fix usrloc slot lock in ul.dump rpc procedure

- unlock usrloc slot when "ul.dump brief" fails during aor struct creation

(cherry picked from commit dfcba5fbcc5046a12babd3c6e93555f89ffa9cbe)

---

Modified: src/modules/usrloc/ul_rpc.c

---

Diff:  https://github.com/kamailio/kamailio/commit/a18cef3bbcc80004d4e013cb7ce08c0b20d8fc8c.diff
Patch: https://github.com/kamailio/kamailio/commit/a18cef3bbcc80004d4e013cb7ce08c0b20d8fc8c.patch

---

diff --git a/src/modules/usrloc/ul_rpc.c b/src/modules/usrloc/ul_rpc.c
index 16864c9cfc..7411be6b93 100644
--- a/src/modules/usrloc/ul_rpc.c
+++ b/src/modules/usrloc/ul_rpc.c
@@ -239,6 +239,7 @@ static void ul_rpc_dump(rpc_t* rpc, void* ctx)
 					if(rpc->struct_add(ah, "S",
 							"AoR", &r->aor)<0)
 					{
+						unlock_ulslot( dom, i);
 						rpc->fault(ctx, 500, "Internal error creating aor struct");
 						return;
 					}


_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[prev in list] [next in list] [prev in thread] [next in thread]