'Re: [sr-dev] dispatcher module. weight based load distribution issue'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sr-dev
Subject:    Re: [sr-dev] dispatcher module. weight based load distribution issue
From:       Daniel-Constantin Mierla <miconda () gmail ! com>
Date:       2015-12-22 12:09:54
Message-ID: 56793D92.4070206 () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Hello,

see algorithm 11:

http://www.kamailio.org/docs/modules/devel/modules/dispatcher.html#dispatcher.f.ds_select_dst

Cheers,
Daniel

On 14/12/15 11:44, Michael Furmur wrote:
> dispatcher module doing wrong when skipping inactive nodes on weighted
> load distribution usage ( alg 9 )
>
> here:
> https://github.com/kamailio/kamailio/blob/master/modules/dispatcher/dispatch.c#L1919
> loop iterates over possible destinations to get first active after
> previously computed destination if it inactive.
>
> this works for all balancing algorythms except of 9 (weighted balancing),
> because on failover it ignores idx->wlist array and chooses next
> destination ignoring weights.
> thus we will get all traffic for inactive destination on the destination
> which next by destinations index.
>
> suggested patch changes behavior to continue to iterate over idx->wlist
> on inactive destinations skipping for alg 9.
>
> please, examine and apply.
>
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev@lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Book: SIP Routing With Kamailio - http://www.asipto.com
http://miconda.eu

[Attachment #5 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Hello,<br>
    <br>
    see algorithm 11:<br>
    <br>
<a class="moz-txt-link-freetext" \
href="http://www.kamailio.org/docs/modules/devel/modules/dispatcher.html#dispatcher.f. \
ds_select_dst">http://www.kamailio.org/docs/modules/devel/modules/dispatcher.html#dispatcher.f.ds_select_dst</a><br>
  <br>
    Cheers,<br>
    Daniel<br>
    <br>
    <div class="moz-cite-prefix">On 14/12/15 11:44, Michael Furmur
      wrote:<br>
    </div>
    <blockquote cite="mid:566E9D90.1030806@gmail.com" type="cite">
      <pre wrap="">dispatcher module doing wrong when skipping inactive nodes on \
weighted load distribution usage ( alg 9 )

here:
<a class="moz-txt-link-freetext" \
href="https://github.com/kamailio/kamailio/blob/master/modules/dispatcher/dispatch.c#L \
1919">https://github.com/kamailio/kamailio/blob/master/modules/dispatcher/dispatch.c#L1919</a>
 loop iterates over possible destinations to get first active after
previously computed destination if it inactive.

this works for all balancing algorythms except of 9 (weighted balancing),
because on failover it ignores idx-&gt;wlist array and chooses next
destination ignoring weights.
thus we will get all traffic for inactive destination on the destination
which next by destinations index.

suggested patch changes behavior to continue to iterate over idx-&gt;wlist
on inactive destinations skipping for alg 9.

please, examine and apply.

</pre>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
sr-dev mailing list
<a class="moz-txt-link-abbreviated" \
href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a> <a \
class="moz-txt-link-freetext" \
href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
 </pre>
    </blockquote>
    <br>
    <pre class="moz-signature" cols="72">-- 
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" \
href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a \
class="moz-txt-link-freetext" \
                href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>

Book: SIP Routing With Kamailio - <a class="moz-txt-link-freetext" \
href="http://www.asipto.com">http://www.asipto.com</a> <a \
class="moz-txt-link-freetext" href="http://miconda.eu">http://miconda.eu</a></pre>  \
</body> </html>

_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

[prev in list] [next in list] [prev in thread] [next in thread] 