[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sr-dev
Subject:    [OpenSER-Devel] [ openser-Patches-1933630 ] dialog callbacks: mi
From:       noreply () sourceforge ! net (SourceForge ! net)
Date:       2008-04-27 16:16:46
Message-ID: E1Jq9YU-0007xZ-1d () sc8-sf-web24 ! sourceforge ! net
[Download RAW message or body]

Patches item #1933630, was opened at 2008-04-03 14:23
Message generated for change (Comment added) made by osas
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1933630&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
> Status: Closed
> Resolution: Fixed
Priority: 5
Private: No
Submitted By: Ovidiu Sas (osas)
Assigned to: Ovidiu Sas (osas)
Summary: dialog callbacks: mi enhancements

Initial Comment:
For modules sitting on top of the dialog module it is not possible to retrieve the \
call specific context out of a callback, because the pointer to the context is stored \
inside the dialog callback structure.

It would make sense to enhance the existing dialog callbacks with a new one that will \
be used by the mi commands to list the call specific context of the data that is hold \
by the module that is sitting on top of the dialog module.

An example is the sst module.  The call specific context is:
typedef struct sst_info_st {
        enum sst_flags requester;
        enum sst_flags supported;
        unsigned int interval;
} sst_info_t;


It would make sense to create a new mi command for the dialog module (like \
dlg_enhanced_list) that will print in addition to the dialog context, the context of \
each module that registered an mi callback with the dialog module.

Thoughts?


Regards,
Ovidiu Sas

----------------------------------------------------------------------

> Comment By: Ovidiu Sas (osas)
Date: 2008-04-27 12:16

Message:
Logged In: YES 
user_id=1395524
Originator: YES

The sst module is updated.

Regards,
Ovidiu Sas

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-04-25 15:24

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Ovidiu,

I did a totally different approach on this issue. Dialog module offers a
new standard callback "DLGCB_MI_CONTEXT" that allows to another module to
add some context to the MI description of the dialog - the callback
receives as param the MI node where the module should add the context.

I guess you will need to rework the sst patch :D..sorry for that.
I will re-assign the patch to you - feel free to commit the sst patch
anytime and close this item.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-04-25 14:37

Message:
Logged In: YES 
user_id=1275325
Originator: NO

No need for changes in the MI API (first step)

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-24 14:48

Message:
Logged In: YES 
user_id=1395524
Originator: YES

Sure.  I would like to modify the signature of add_mi_sibling_node() to
return the last node in the mi tree.
Like this the following code from dlg_hash.c:mi_print_dlgs
		add_mi_sibling_node( node1, node2);
		if (node2)
			node1 = node2;
would simply turn into:
		node1 = add_mi_sibling_node( node1, node2);


Regards,
Ovidiu Sas

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-04-24 12:56

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Give me one day to look over the patch...

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-24 12:24

Message:
Logged In: YES 
user_id=1395524
Originator: YES

If there are no objections, I will push in the new mi_helper dialog API by
the end of the week.

Regards,
Ovidiu Sas

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-23 14:28

Message:
Logged In: YES 
user_id=1395524
Originator: YES

I updated the dialog.patch and sst.patch files according to the discussion
from the mailing list.

Regards,
Ovidiu Sas

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-23 14:26

Message:
Logged In: YES 
user_id=1395524
Originator: YES

File Added: sst.patch

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-23 14:24

Message:
Logged In: YES 
user_id=1395524
Originator: YES

File Added: dialog.patch

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-16 13:16

Message:
Logged In: YES 
user_id=1395524
Originator: YES

Sure, I agree with that, that's why I committed only the mi part of the
proposed patch.
The patches were made available 5 days ago ... but I received no feedback
on this ...

Maybe we should schedule a monthly irc dev meeting to discuss new
development work.


Regards,
Ovidiu Sas

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2008-04-16 12:10

Message:
Logged In: YES 
user_id=337916
Originator: NO

Yes, the bug tracker is probably not the best place for discussing things
like this, this should be better done on the list.



----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-04-16 12:01

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Ovidiu,

I would prefer to have such changes discussed and correlated between
developers in order to find the best solution. Consider that a one day
deadline for commits it's a bit too short for me - but I'm still in favour
of not rushing things without a proper consideration of the matter.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-15 10:45

Message:
Logged In: YES 
user_id=1395524
Originator: YES

If there are no objections, I will push the patch into the gate this
week.

Regards,
Ovidiu Sas

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-11 19:34

Message:
Logged In: YES 
user_id=1395524
Originator: YES

re-targeting "Feature Request" -> "Patches"

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-11 19:33

Message:
Logged In: YES 
user_id=1395524
Originator: YES

File Added: sst.patch

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-11 19:32

Message:
Logged In: YES 
user_id=1395524
Originator: YES

File Added: dialog.patch

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-11 19:31

Message:
Logged In: YES 
user_id=1395524
Originator: YES

Here are some proposed patches for adding this new feature:
 - mi.patch
   - provides enhancements to the mi API (build an mi node out of the tree
structure)
 - dialog.patch
   - new callback: DLGCB_MI_CTX_QUERY (callback for mi query commands)
 - sst.patch
   - first module to use the DLGCB_MI_CTX_QUERY


Here's the result:
dialog::  hash=898:913256572
        state:: 2
        timestart:: 0
        timeout:: 0
        callid:: 1-24613 at 10.11.10.148
        from_uri:: sip:sipp at 10.11.10.148:5050
        from_tag:: 1
        caller_contact:: sip:sipp at 10.11.10.148:5050
        caller_cseq:: 1
        caller_route_set:: 
        caller_bind_addr:: udp:10.11.10.63:5060
        to_uri:: sip:4165555001 at 10.11.10.63:5060
        to_tag:: 
        callee_contact:: 
        callee_cseq:: 
        callee_route_set:: 
        callee_bind_addr:: 
        sst::  requester_flags=4 supported_flags=0 interval=2400



Regards,
Ovidiu Sas
File Added: mi.patch

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1933630&group_id=139143


[prev in list] [next in list] [prev in thread] [next in thread]