[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squirrelmail-plugins
Subject:    Re: [SM-PLUGINS] spam_buttons email report patch
From:       "Paul Lesniewski" <paul () squirrelmail ! org>
Date:       2006-11-30 23:03:07
Message-ID: 58191e420611301503v47b31e6fo90284f16d92c3b89 () mail ! gmail ! com
[Download RAW message or body]

Hugo,

> Dunno if anyone has patched this already, but either way here it is.
> The Spam Buttons plugin i downloaded from the squirrelmail site wasn't
> working properly when one tried to use the constants
> ###EMAIL_ADDRESS###, ###USERNAME### and ###DOMAIN###.

I don't know why you suggest this is a bug when the documentation does
not indicate that those constants are available for the email
mechanism.  You should suggest this as an added functionality instead.

> I've made a small patch, that's nothing more than a rip off of the
> substitution code from the shell command report function into the mail
> report function.

Can't hurt to add this, but can you explain a situation when the
reporting addresses have to have those constants in them?  What do
your reporting addresses look like?

Also, please submit patches in unified diff format in the future.

Thanks for the patch,

Paul

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
--
squirrelmail-plugins mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: squirrelmail-plugins@lists.sourceforge.net
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.plugins
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=3931
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-plugins
[prev in list] [next in list] [prev in thread] [next in thread]