[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squirrelmail-devel
Subject:    [SM-DEVEL] Corification of Compatibility plugin (was: New change_passwd update)
From:       Paul Lesneiwski <paul () squirrelmail ! org>
Date:       2005-12-07 10:29:38
Message-ID: 4396B992.7040700 () squirrelmail ! org
[Download RAW message or body]

All,

>>> Plugins should not require patching SquirrelMail source.
>>
>> Absolutely.  However, the nature of what this one needs to do is a bit
>> unique and can't be achieved any other way that I can see... and I've
>> looked a lot, but suggestions are welcome.
>>
>>> We can add code that
>>> loads compatibily functions, if plugins/compatibility/functions.php
>>> exists.
>>
>> If we do, we should probably just have the discussion about putting that
>> plugin into the core package plugins.  In fact, Erin and I had a long
>> thread on the devel list probably over a year ago where we decided to do
>> exactly that once the plugin was designed appropriately (I think it now is
>> - more or less).  The good and bad thing about that is that it still
>> has to be made available in a way that people running older SM versions
>> can get the latest tarball easily, and it needs to be kept up to date by
>> developers who change key code that is used in the plugin (such as many of
>> the functions in global.php).
>...
>> I can make that change w/out too much trouble.  The question here is if
>> it is still desirable to pull the plugin into core, or if Tomas' idea is
>> preferable.
>
> My opinion. Compatibility plugin should not be distributed with
> SquirrelMail packages. If plugin is part of SquirrelMail distribution,
> included version won't cover plugin updates added after SquirrelMail
> package is released. In order to get current plugin version, admins
> will
> have to replace files that are part of standard SquirrelMail package.
> Same
> "don't mod prepackaged scripts" problem. Plugin can be maintained in
> SquirrelMail cvs, but it must be distributed in separate package.

Sure, I don't think anyone wants to advocate that the plugin should be
distributed with the core tarball, but that it is maintained by the team
in SM CVS.

> In order to avoid modifications in SquirrelMail scripts, we make sure
> that
> include call place is fixed, plugin's API functions are stabilized and
> include it with
>
> if(file_exists(SM_PATH.'plugins/compatibility/functions.php'))
>   include_once(SM_PATH.'plugins/compatibility/functions.php'));

I will add this to DEVEL.  Can I get STABLE admins' opinions on this?


I will work on putting the compatibility plugin in SM CVS in the next
couple weeks I hope.



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: squirrelmail-devel@lists.sourceforge.net
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]