[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squirrelmail-cvs
Subject:    [SM-CVS] SF.net SVN: squirrelmail:[14244]
From:       pdontthink () users ! sourceforge ! net
Date:       2011-12-29 2:53:37
Message-ID: E1Rg67d-00065o-PM () sfp-svn-3 ! v30 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Revision: 14244
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=14244&view=rev
Author:   pdontthink
Date:     2011-12-29 02:53:37 +0000 (Thu, 29 Dec 2011)
Log Message:
-----------
No longer require a source file edit to enable listing of LDAP address books

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/doc/ChangeLog
    branches/SM-1_4-STABLE/squirrelmail/functions/abook_ldap_server.php

Modified: branches/SM-1_4-STABLE/squirrelmail/doc/ChangeLog
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/doc/ChangeLog	2011-12-29 01:34:06 UTC (rev \
                14243)
+++ branches/SM-1_4-STABLE/squirrelmail/doc/ChangeLog	2011-12-29 02:53:37 UTC (rev \
14244) @@ -24,6 +24,12 @@
     search in fields other than first/last name (nickname, email); LDAP-
     backed address books now search in common name fields as well as by
     email address (cn, sn, givenname, mail)
+  - You may now enable LDAP-backed address books to be listed (using
+    the "List all" button on the address search screen accessed via
+    the "Addresses" button on the compose screen) by adding
+    "$ldap_abook_allow_listing = TRUE;" (without quotes) to
+    config/config_local.php (previously, this required editing of a
+    file).
 
 Version 1.4.22 - 12 July 2011
 -----------------------------

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/abook_ldap_server.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/abook_ldap_server.php	2011-12-29 \
                01:34:06 UTC (rev 14243)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/abook_ldap_server.php	2011-12-29 \
02:53:37 UTC (rev 14244) @@ -365,15 +365,27 @@
     /**
      * List all entries present in LDAP server
      *
-     * If you run a tiny LDAP server and you want the "List All" button
-     * to show EVERYONE, disable first return call and enable the second one.
-     * Remember that maxrows setting might limit list of returned entries.
+     * If you run a small-sized LDAP server and you want the "List all"
+     * button (found on the address book search screen that is accessed
+     * via the "Addresses" button on the compose screen) to show all
+     * addresses in the directory, add the following to config/config_local.php
      *
-     * Careful with this -- it could get quite large for big sites.
+     *    $ldap_abook_allow_listing = TRUE;
+     *
+     * Remember that the "maxrows" configuration setting for the LDAP
+     * server backend might limit list of returned entries.
+     *
+     * NOTE: You should exercise caution enabling the listing of large
+     *       or public LDAP address book backends.
+     *
      * @return array all entries in ldap server
+     *
      */
      function list_addr() {
-         return array();
-         // return $this->search('*');
+         global $ldap_abook_allow_listing;
+         if ($ldap_abook_allow_listing)
+            return $this->search('*');
+         else
+            return array();
      }
 }

This was sent by the SourceForge.net collaborative development platform, the world's \
largest Open Source development site.


------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
-----
squirrelmail-cvs mailing list
List address: squirrelmail-cvs@lists.sourceforge.net
List info (subscribe/unsubscribe/change options): \
                https://lists.sourceforge.net/lists/listinfo/squirrelmail-cvs
Repository: http://squirrelmail.org/svn


[prev in list] [next in list] [prev in thread] [next in thread]