[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squirrelmail-cvs
Subject:    Re: [SM-CVS] SF.net SVN: squirrelmail:[14146]
From:       "Fredrik Jervfors" <jervfors () squirrelmail ! org>
Date:       2011-09-26 11:30:02
Message-ID: fd5d592388034c614ce3ebe6d6921724.squirrel () testing ! fimbul ! net
[Download RAW message or body]

> > function sq_call_function_suppress_errors($function, $args=array()) {
> > $display_errors = ini_get('display_errors');
> > ini_set('display_errors', '0');
> > -   $ret = call_user_func_array($function, $args);
> > +   if ( is_null( $args ) ) {
> > +     $ret = call_user_func($function);
> > +   } else {
> > +     $ret = call_user_func_array($function, $args);
> > +   }
> > 
> 
> I don't think I like this patch.  It's caused by buggy code in the
> caller and just masks a problem there (which, IIRC, was fixed).
> 
> The person who submitted the patch only looked far enough to figure
> out this band-aid solution.  It's not terrible, but we don't do a lot of
> assertion-type checking of function arguments in SM and I'd rather stay
> consistent and fix the caller that triggers such bugs.
> 
> I can reverse it, but wanted to check in before I did that.

Fixing the source is better than adding a work-around. Please go ahead.

--
Fredrik Jervfors
The SquirrelMail Project
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donations.php


------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
-----
squirrelmail-cvs mailing list
List address: squirrelmail-cvs@lists.sourceforge.net
List info (subscribe/unsubscribe/change options): \
                https://lists.sourceforge.net/lists/listinfo/squirrelmail-cvs
Repository: http://squirrelmail.org/svn


[prev in list] [next in list] [prev in thread] [next in thread]