[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squirrelmail-cvs
Subject:    [SM-CVS] SF.net SVN: squirrelmail:[14035]
From:       pdontthink () users ! sourceforge ! net
Date:       2010-07-25 19:41:22
Message-ID: E1Od74c-0000jj-F3 () sfp-svn-6 ! v30 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Revision: 14035
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=14035&view=rev
Author:   pdontthink
Date:     2010-07-25 19:41:21 +0000 (Sun, 25 Jul 2010)

Log Message:
-----------
Fix message cache corruption (#3034317)

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/src/view_text.php

Modified: branches/SM-1_4-STABLE/squirrelmail/src/view_text.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/src/view_text.php	2010-07-25 17:56:54 UTC \
                (rev 14034)
+++ branches/SM-1_4-STABLE/squirrelmail/src/view_text.php	2010-07-25 19:41:21 UTC \
(rev 14035) @@ -49,7 +49,14 @@
 $imapConnection = sqimap_login($username, $key, $imapServerAddress, $imapPort, 0);
 $mbx_response = sqimap_mailbox_select($imapConnection, $mailbox);
 
-$message = &$messages[$mbx_response['UIDVALIDITY']][$passed_id];
+// were we using a reference here just to save memory?
+// problem is that below if $passed_ent_id is given,
+// the message cache now points to that entity and not
+// the original message (corrupts the cache)
+//
+//$message = &$messages[$mbx_response['UIDVALIDITY']][$passed_id];
+//
+$message = $messages[$mbx_response['UIDVALIDITY']][$passed_id];
 $message_ent = $message->getEntity($ent_id);
 if ($passed_ent_id) {
     $message = &$message->getEntity($passed_ent_id);


This was sent by the SourceForge.net collaborative development platform, the world's \
largest Open Source development site.

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
-----
squirrelmail-cvs mailing list
List address: squirrelmail-cvs@lists.sourceforge.net
List info (subscribe/unsubscribe/change options): \
                https://lists.sourceforge.net/lists/listinfo/squirrelmail-cvs
Repository: http://squirrelmail.org/svn


[prev in list] [next in list] [prev in thread] [next in thread]