[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squirrelmail-cvs
Subject:    [SM-CVS] SF.net SVN: squirrelmail:[13853]
From:       pdontthink () users ! sourceforge ! net
Date:       2009-10-04 5:08:14
Message-ID: E1MuJKQ-0003pY-CJ () d5vjzd1 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Revision: 13853
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=13853&view=rev
Author:   pdontthink
Date:     2009-10-04 05:08:14 +0000 (Sun, 04 Oct 2009)

Log Message:
-----------
Duh, look at the content of the regex and see that some aren't using a-z, so i \
modifier is superfluous

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/functions/addressbook.php
    branches/SM-1_4-STABLE/squirrelmail/src/view_header.php

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/addressbook.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/addressbook.php	2009-10-04 04:59:24 \
                UTC (rev 13852)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/addressbook.php	2009-10-04 05:08:14 \
UTC (rev 13853) @@ -520,7 +520,7 @@
             $userdata['nickname'] = $userdata['email'];
         }
 
-        if (preg_match('/[ :|#"!]/i', $userdata['nickname'])) {
+        if (preg_match('/[ :|#"!]/', $userdata['nickname'])) {
             $this->error = _("Nickname contains illegal characters");
             return false;
         }
@@ -604,7 +604,7 @@
             return false;
         }
 
-        if (preg_match('/[: |#"!]/i', $userdata['nickname'])) {
+        if (preg_match('/[: |#"!]/', $userdata['nickname'])) {
             $this->error = _("Nickname contains illegal characters");
             return false;
         }

Modified: branches/SM-1_4-STABLE/squirrelmail/src/view_header.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/src/view_header.php	2009-10-04 04:59:24 UTC \
                (rev 13852)
+++ branches/SM-1_4-STABLE/squirrelmail/src/view_header.php	2009-10-04 05:08:14 UTC \
(rev 13853) @@ -54,11 +54,11 @@
                 $cnum++;
                 break;
 // FIXME: is the pipe character below a mistake?  I think the original author might \
have thought it carried special meaning in the character class, which it does not... \
                but then again, I am not currently trying to understand what this \
                code actually does
-            case (preg_match('/^[ |\t]/i', $line)):
+            case (preg_match('/^[ |\t]/', $line)):
                 $second[$i] = $line;
                 $first[$i] = '';
                 break;
-            case (preg_match('/^([^:]+):(.+)/i', $line, $regs)):
+            case (preg_match('/^([^:]+):(.+)/', $line, $regs)):
                 $first[$i] = $regs[1] . ':';
                 $second[$i] = $regs[2];
                 $cnum++;


This was sent by the SourceForge.net collaborative development platform, the world's \
largest Open Source development site.

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-cvs mailing list
List address: squirrelmail-cvs@lists.sourceforge.net
List info (subscribe/unsubscribe/change options): \
                https://lists.sourceforge.net/lists/listinfo/squirrelmail-cvs
Repository: http://squirrelmail.org/svn


[prev in list] [next in list] [prev in thread] [next in thread]