[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squirrelmail-cvs
Subject:    [SM-CVS] SF.net SVN: squirrelmail:[13767]
From:       pdontthink () users ! sourceforge ! net
Date:       2009-05-26 18:05:35
Message-ID: E1M911r-0005QF-Hq () c3vjzd1 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Revision: 13767
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=13767&view=rev
Author:   pdontthink
Date:     2009-05-26 18:05:35 +0000 (Tue, 26 May 2009)

Log Message:
-----------
QUERY_STRING is already sanitized

Modified Paths:
--------------
    trunk/squirrelmail/functions/attachment_common.php

Modified: trunk/squirrelmail/functions/attachment_common.php
===================================================================
--- trunk/squirrelmail/functions/attachment_common.php	2009-05-26 13:11:31 UTC (rev \
                13766)
+++ trunk/squirrelmail/functions/attachment_common.php	2009-05-26 18:05:35 UTC (rev \
13767) @@ -148,7 +148,7 @@
     sqgetGlobalVar('QUERY_STRING', $QUERY_STRING, SQ_SERVER);
 
     // if htmlspecialchars() breaks something - find other way to encode & in url.
-    $Args[0]['attachment_common']['href'] = $base_uri  . 'src/view_text.php?'. \
htmlspecialchars($QUERY_STRING); +    $Args[0]['attachment_common']['href'] = \
$base_uri  . 'src/view_text.php?'. $QUERY_STRING;  \
$Args[0]['attachment_common']['href'] =  \
set_url_var($Args[0]['attachment_common']['href'],  'ent_id',$Args[4]);
@@ -192,7 +192,7 @@
     global $base_uri;
     sqgetGlobalVar('QUERY_STRING', $QUERY_STRING, SQ_SERVER);
 
-    $Args[0]['attachment_common']['href'] = $base_uri  . 'src/view_text.php?'. \
htmlspecialchars($QUERY_STRING). +    $Args[0]['attachment_common']['href'] = \
$base_uri  . 'src/view_text.php?'. $QUERY_STRING.  /* why use the overridetype? can \
                this be removed */
         /* override_type might be needed only when we want view other type of \
messages as html */  '&override_type0=text&override_type1=html';


This was sent by the SourceForge.net collaborative development platform, the world's \
largest Open Source development site.

------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT 
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian 
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com 
-----
squirrelmail-cvs mailing list
List address: squirrelmail-cvs@lists.sourceforge.net
List info (subscribe/unsubscribe/change options): \
                https://lists.sourceforge.net/lists/listinfo/squirrelmail-cvs
Repository: http://squirrelmail.org/svn


[prev in list] [next in list] [prev in thread] [next in thread]