[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squirrelmail-cvs
Subject:    [SM-CVS] SF.net SVN: squirrelmail:[13368]
From:       pdontthink () users ! sourceforge ! net
Date:       2008-12-18 1:10:42
Message-ID: E1LD7PW-0006pR-QT () 74yxhf1 ! ch3 ! sourceforge ! com
[Download RAW message or body]

Revision: 13368
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=13368&view=rev
Author:   pdontthink
Date:     2008-12-18 01:10:42 +0000 (Thu, 18 Dec 2008)

Log Message:
-----------
Add notes about issue reported where unset() breaks when removing attachments

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/src/compose.php

Modified: branches/SM-1_4-STABLE/squirrelmail/src/compose.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/src/compose.php	2008-12-08 20:19:18 UTC (rev \
                13367)
+++ branches/SM-1_4-STABLE/squirrelmail/src/compose.php	2008-12-18 01:10:42 UTC (rev \
13368) @@ -588,6 +588,9 @@
         foreach($delete as $index) {
             if (!empty($composeMessage->entities) && \
isset($composeMessage->entities[$index])) {  \
$composeMessage->entities[$index]->purgeAttachments(); +                // FIXME: one \
person reported that unset() didn't do anything at all here, so this is a \
work-around... but it triggers PHP notices if the unset() doesn't work, which should \
be fixed... but bigger question is if unset() doesn't work here, what about \
everywhere else? +Anyway, uncomment this if you think you need it
+                //$composeMessage->entities[$index] = NULL;
                 unset ($composeMessage->entities[$index]);
             }
         }


This was sent by the SourceForge.net collaborative development platform, the world's \
largest Open Source development site.

------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
-----
squirrelmail-cvs mailing list
List address: squirrelmail-cvs@lists.sourceforge.net
List info (subscribe/unsubscribe/change options): \
                https://lists.sourceforge.net/lists/listinfo/squirrelmail-cvs
Repository: http://squirrelmail.org/svn


[prev in list] [next in list] [prev in thread] [next in thread]