[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squirrelmail-cvs
Subject:    [SM-CVS] SF.net SVN: squirrelmail: [12901]
From:       pdontthink () users ! sourceforge ! net
Date:       2008-01-29 23:09:44
Message-ID: E1JJzaK-00085D-2y () sc8-pr-svn2 ! sourceforge ! net
[Download RAW message or body]

Revision: 12901
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=12901&view=rev
Author:   pdontthink
Date:     2008-01-29 15:09:43 -0800 (Tue, 29 Jan 2008)

Log Message:
-----------
Avoid E_STRICT errors

Modified Paths:
--------------
    trunk/squirrelmail/functions/attachment_common.php

Modified: trunk/squirrelmail/functions/attachment_common.php
===================================================================
--- trunk/squirrelmail/functions/attachment_common.php	2008-01-29 23:08:26 UTC (rev \
                12900)
+++ trunk/squirrelmail/functions/attachment_common.php	2008-01-29 23:09:43 UTC (rev \
12901) @@ -248,6 +248,7 @@
 function attachment_common_octet_stream(&$Args) {
     global $FileExtensionToMimeType, $null;
 
+//FIXME: I propose removing this hook; I don't like having two hooks close together, \
but moreover, this hook appears to merely give plugins the chance to add to the \
global $FileExtensionToMimeType variable, which they can do in any hook before now - \
I'd recommend prefs_backend (which is what config_override used to be) because it's \
the one hook run at the beginning of almost all page requests in init.php -- the con \
is that we don't need it run on ALL page requests, do we?  There may be another hook \
in THIS page request that we can recommend, in which case, we *really should* remove \
this hook here.  do_hook('attachment_common-load_mime_types', $null);
 
     ereg('\\.([^\\.]+)$', $Args[6], $Regs);
@@ -257,8 +258,8 @@
     if ($Ext == '' || ! isset($FileExtensionToMimeType[$Ext]))
         return;
 
-    do_hook('attachment ' . $FileExtensionToMimeType[$Ext],
-        $temp=array(&$Args[0], &$Args[1], &$Args[2], &$Args[3], &$Args[4], \
                &$Args[5],
-        &$Args[6], &$Args[7], &$Args[8]));
+    $temp=array(&$Args[0], &$Args[1], &$Args[2], &$Args[3], &$Args[4], &$Args[5],
+                &$Args[6], &$Args[7], &$Args[8]);
+    do_hook('attachment ' . $FileExtensionToMimeType[$Ext], $temp);
 
 }


This was sent by the SourceForge.net collaborative development platform, the world's \
largest Open Source development site.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
-----
squirrelmail-cvs mailing list
List address: squirrelmail-cvs@lists.sourceforge.net
List info (subscribe/unsubscribe/change options): \
                https://lists.sourceforge.net/lists/listinfo/squirrelmail-cvs
Repository: http://squirrelmail.org/svn


[prev in list] [next in list] [prev in thread] [next in thread]