[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squirrelmail-cvs
Subject:    [SM-CVS] SF.net SVN: squirrelmail: [12746]
From:       jangliss () users ! sourceforge ! net
Date:       2007-10-30 16:28:43
Message-ID: E1ImtxL-0008Ut-Tt () sc8-pr-svn2 ! sourceforge ! net
[Download RAW message or body]

Revision: 12746
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=12746&view=rev
Author:   jangliss
Date:     2007-10-30 09:28:43 -0700 (Tue, 30 Oct 2007)

Log Message:
-----------
Multiple "undefined" warnings reported by Cor.

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/ChangeLog
    branches/SM-1_4-STABLE/squirrelmail/functions/auth.php
    branches/SM-1_4-STABLE/squirrelmail/functions/display_messages.php
    branches/SM-1_4-STABLE/squirrelmail/src/download.php

Modified: branches/SM-1_4-STABLE/squirrelmail/ChangeLog
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/ChangeLog	2007-10-28 00:30:54 UTC (rev 12745)
+++ branches/SM-1_4-STABLE/squirrelmail/ChangeLog	2007-10-30 16:28:43 UTC (rev 12746)
@@ -9,6 +9,12 @@
   - Fixed issue with adding attachments in PHP 4.x environments (#1805471).
   - Backport size setting on "newmail" popup window.
   - Added a "short_open_tag" configuration test.
+  - Undefined notice in error message box when no default folder prefix is set.
+  - Undefined index error when downloading.  Possibly caused by using tabs and
+    opening multiple mailboxes.
+  - PAGE_NAME might not be defined in all plugins, which might cause a 
+    "not defined" error on session timeouts.
+  
 
 Version 1.4.11 - 29 September 2007
 ----------------------------------

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/auth.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/auth.php	2007-10-28 00:30:54 UTC \
                (rev 12745)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/auth.php	2007-10-30 16:28:43 UTC \
(rev 12746) @@ -54,7 +54,10 @@
         //  First we store some information in the new session to prevent
         //  information-loss.
         $session_expired_post = $_POST;
-        $session_expired_location = PAGE_NAME;
+        if (defined('PAGE_NAME')) {
+            $session_expired_location = PAGE_NAME;
+        }
+        
         if (!sqsession_is_registered('session_expired_post')) {
             sqsession_register($session_expired_post,'session_expired_post');
         }

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/display_messages.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/display_messages.php	2007-10-28 \
                00:30:54 UTC (rev 12745)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/display_messages.php	2007-10-30 \
16:28:43 UTC (rev 12746) @@ -26,9 +26,11 @@
               '<tr><td align="center">'.
               '<a href="'.sqm_baseuri()."src/right_main.php?sort=$sort&amp;startMessage=$startMessage&amp;mailbox=$urlMailbox\">";
  
-    if (strpos($mailbox, $default_folder_prefix) === 0)
-        $mailbox = substr($mailbox, strlen($default_folder_prefix));
-
+    if (!empty($default_folder_prefix)) {
+        if (strpos($mailbox, $default_folder_prefix) === 0)
+            $mailbox = substr($mailbox, strlen($default_folder_prefix));
+    }
+    
     $string .= sprintf (_("Click here to return to %s"),
                   htmlspecialchars(imap_utf7_decode_local($mailbox))).
               '</a></td></tr>';

Modified: branches/SM-1_4-STABLE/squirrelmail/src/download.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/src/download.php	2007-10-28 00:30:54 UTC (rev \
                12745)
+++ branches/SM-1_4-STABLE/squirrelmail/src/download.php	2007-10-30 16:28:43 UTC (rev \
12746) @@ -51,10 +51,16 @@
 $imapConnection = sqimap_login($username, $key, $imapServerAddress, $imapPort, 0);
 $mbx_response =  sqimap_mailbox_select($imapConnection, $mailbox);
 
-$message = $messages[$mbx_response['UIDVALIDITY']]["$passed_id"];
+$message = '';
+
+if (isset($messages[$mbx_response['UIDVALIDITY']]["$passed_id"])) {
+    $message = $messages[$mbx_response['UIDVALIDITY']]["$passed_id"];
+}
+
 if (!is_object($message)) {
     $message = sqimap_get_message($imapConnection,$passed_id, $mailbox);
 }
+
 $subject = $message->rfc822_header->subject;
 if ($ent_id) {
     $message = $message->getEntity($ent_id);


This was sent by the SourceForge.net collaborative development platform, the world's \
largest Open Source development site.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
--
squirrelmail-cvs mailing list
List Address: squirrelmail-cvs@lists.sourceforge.net
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-cvs
http://squirrelmail.org/cvs


[prev in list] [next in list] [prev in thread] [next in thread]