[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squirrelmail-cvs
Subject:    [SM-CVS] CVS: squirrelmail/src search.php,1.92.2.8,1.92.2.9
From:       Thijs Kinkhorst <kink () users ! sourceforge ! net>
Date:       2005-05-30 9:49:42
Message-ID: E1Dcgty-0000Tc-9R () sc8-pr-cvs1 ! sourceforge ! net
[Download RAW message or body]

Update of /cvsroot/squirrelmail/squirrelmail/src
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv966/src

Modified Files:
      Tag: SM-1_4-STABLE
	search.php 
Log Message:
Saved searches: fix off-by-one bug (array is numbered 0,1,2 and code
iterated over 1,2,3) and HTML-formatting (probably html_tag copy-paste error).
Appearently this feature isn't used much because it was obviously broken.


Index: search.php
===================================================================
RCS file: /cvsroot/squirrelmail/squirrelmail/src/search.php,v
retrieving revision 1.92.2.8
retrieving revision 1.92.2.9
diff -u -w -r1.92.2.8 -r1.92.2.9
--- search.php	13 Mar 2005 02:30:53 -0000	1.92.2.8
+++ search.php	30 May 2005 09:49:39 -0000	1.92.2.9
@@ -315,27 +315,27 @@
         } else {
             echo html_tag( 'tr', '', '', $color[4] );
         }
-        echo html_tag( 'td', \
imap_utf7_decode_local($saved_attributes['saved_folder'][$i + 1]), 'left', '', \
                'width="35%"' )
-        . html_tag( 'td', $saved_attributes['saved_what'][$i + 1], 'left' )
-        . html_tag( 'td', $saved_attributes['saved_where'][$i + 1], 'center' )
-        . html_tag( 'td', '', 'right' )
-        .   '<a href="search.php'
-        .     '?mailbox=' . htmlspecialchars($saved_attributes['saved_folder'][$i + \
                1])
-        .     '&amp;what=' . htmlspecialchars($saved_attributes['saved_what'][$i + \
                1])
-        .     '&amp;where=' . htmlspecialchars($saved_attributes['saved_where'][$i + \
1]) +        echo html_tag( 'td', \
imap_utf7_decode_local($saved_attributes['saved_folder'][$i]), 'left', '', \
'width="35%"' ) +        . html_tag( 'td', $saved_attributes['saved_what'][$i], \
'left' ) +        . html_tag( 'td', $saved_attributes['saved_where'][$i], 'center' )
+        . html_tag( 'td', 
+           '<a href="search.php'
+        .     '?mailbox=' . htmlspecialchars($saved_attributes['saved_folder'][$i])
+        .     '&amp;what=' . htmlspecialchars($saved_attributes['saved_what'][$i])
+        .     '&amp;where=' . htmlspecialchars($saved_attributes['saved_where'][$i])
         .   '">' . _("edit") . '</a>'
         .   '&nbsp;|&nbsp;'
         .   '<a href="search.php'
-        .     '?mailbox=' . urlencode($saved_attributes['saved_folder'][$i + 1])
-        .     '&amp;what=' . urlencode($saved_attributes['saved_what'][$i + 1])
-        .     '&amp;where=' . urlencode($saved_attributes['saved_where'][$i + 1])
+        .     '?mailbox=' . urlencode($saved_attributes['saved_folder'][$i])
+        .     '&amp;what=' . urlencode($saved_attributes['saved_what'][$i])
+        .     '&amp;where=' . urlencode($saved_attributes['saved_where'][$i])
         .     '&amp;submit=Search_no_update'
         .   '">' . _("search") . '</a>'
         .   '&nbsp;|&nbsp;'
         .   "<a href=\"search.php?count=$i&amp;submit=delete\">"
         .     _("delete")
-        .   '</a>'
-        . '</td></tr>';
+        .   '</a>', 'center')
+        . '</tr>';
     }
     echo "</table></td></tr></table>\n";
 }



-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
--
squirrelmail-cvs mailing list
List Address: squirrelmail-cvs@lists.sourceforge.net
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-cvs
http://squirrelmail.org/cvs


[prev in list] [next in list] [prev in thread] [next in thread]