[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squirrelmail-cvs
Subject:    [SM-CVS] CVS: squirrelmail/functions page_header.php,1.175,1.176
From:       Paul Lesneiwski <pdontthink () users ! sourceforge ! net>
Date:       2004-11-24 22:33:13
Message-ID: E1CX5hJ-0002FC-Mm () sc8-pr-cvs1 ! sourceforge ! net
[Download RAW message or body]

Update of /cvsroot/squirrelmail/squirrelmail/functions
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv8589/functions

Modified Files:
	page_header.php 
Log Message:
Following up on my long standing threat to remove internal_link hook.  Templates make \
it unnecessary, it is inefficient, and the only plugin using it requires a source \
patch to the same code anyway.

Index: page_header.php
===================================================================
RCS file: /cvsroot/squirrelmail/squirrelmail/functions/page_header.php,v
retrieving revision 1.175
retrieving revision 1.176
diff -u -w -r1.175 -r1.176
--- page_header.php	2 Nov 2004 22:21:23 -0000	1.175
+++ page_header.php	24 Nov 2004 22:33:11 -0000	1.176
@@ -96,9 +96,18 @@
     if ($target != '') {
         $target = " target=\"$target\"";
     }
-    $hooktext = do_hook_function('internal_link',$text);
-    if ($hooktext != '')
-        $text = $hooktext;
+
+    // This is an inefficient hook and is only used by 
+    // one plugin that still needs to patch this code,
+    // plus if we are templat-izing SM, visual hooks 
+    // are not needed.  However, I am leaving the code 
+    // here just in case we find a good (non-visual?) 
+    // use for the internal_link hook.
+    //
+    //$hooktext = do_hook_function('internal_link',$text);
+    //if ($hooktext != '')
+    //    $text = $hooktext;
+
     return '<a href="'.$base_uri.$path.'"'.$target.'>'.$text.'</a>';
 }
 



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
--
squirrelmail-cvs mailing list
List Address: squirrelmail-cvs@lists.sourceforge.net
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-cvs
http://squirrelmail.org/cvs


[prev in list] [next in list] [prev in thread] [next in thread]