[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squid-dev
Subject:    Re: [squid-dev] [PATCH] Extend SBufContainerJoin to have prefix and suffix arguments
From:       Alex Rousskov <rousskov () measurement-factory ! com>
Date:       2016-11-11 17:59:52
Message-ID: 89dfb1db-267c-7ff0-bee0-9b5f456a4900 () measurement-factory ! com
[Download RAW message or body]

On 11/10/2016 01:28 PM, Kinkie wrote:

> +/// convenience wrapper of JoinContainerIntoSBuf with no caller-supplied SBuf
> +template <class ContainerIterator>
> +SBuf
> +JoinContainerToSBuf(const ContainerIterator &begin,

IMO, the description should disclose the performance overhead of the
convenience wrapper [instead of stating the obvious lack of the
caller-supplied SBuf]. I have proposed a specific wording, but it does
not have to be that wording, of course.


> v4 attached.

v5, actually.

I am OK with these changes going in, hopefully after the description
adjustment discussed above.


Thank you,

Alex.

_______________________________________________
squid-dev mailing list
squid-dev@lists.squid-cache.org
http://lists.squid-cache.org/listinfo/squid-dev

[prev in list] [next in list] [prev in thread] [next in thread]