[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squid-dev
Subject:    Re: [squid-dev] [PATCH] Avoid startup/shutdown crashes
From:       Alex Rousskov <rousskov () measurement-factory ! com>
Date:       2016-04-11 15:19:01
Message-ID: 570BC065.2020806 () measurement-factory ! com
[Download RAW message or body]

On 04/09/2016 10:16 PM, Amos Jeffries wrote:
> On 7/04/2016 6:04 p.m., Alex Rousskov wrote:
>> Hello,
>>
>>     We spent the last few days chasing down trunk startup crashes.
>> Backtraces pointed to the OpenSSL context management bugs, but the
>> actual problem was related to the global destruction disorder in the
>> SBuf statistics code. The attached patch preamble contains the proposed
>> commit message with more technical details, as usual.


> Since the new functions are global scope they need to start with upper
> case..

The patch does not add or rename global functions. While I hated the old
function names, I resisted the temptation to rename them in order to
avoid wasting time on debates about the new names.


> Other than that +1 and please commit ASAP.


Committed to trunk (r14636).


Thank you,

Alex.

_______________________________________________
squid-dev mailing list
squid-dev@lists.squid-cache.org
http://lists.squid-cache.org/listinfo/squid-dev

[prev in list] [next in list] [prev in thread] [next in thread]