[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squid-dev
Subject:    Re: [squid-dev] [PATCH] mempools-nozero part 4: debug
From:       Kinkie <gkinkie () gmail ! com>
Date:       2015-08-24 17:51:24
Message-ID: CA+Y8hcOhMcHxrtZzXjgyrj=i0Fav0dmbY=mZZtSAbFz1rNQy7A () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Merged with requested changes as r14244.

On Mon, Aug 24, 2015 at 7:10 PM, Amos Jeffries <squid3@treenet.co.nz> wrote:

> On 25/08/2015 3:36 a.m., Kinkie wrote:
> > Hi,
> >   part 4 (of 5) patches from the mempools-nozero branch: debug
> >
> > This patch transforms Debug::OutStream into a MEMPROXY_CLASS instead of
> > rolling its own new and delete operators. The biggest changes come from
> > pulling in various Makefile.am files the necessary dependencies.
> > I've taken the chance to also rely more on Makefile variables in various
> > file-copying recipes in order to simplify them a bit.
> >
> > Patch with big context attached.
> >
>
> in src/icmp/Makefile.am:
> * "#libmem is needed for"looks like it should be up on COPIED_SOURCE
>  - I see no libmem/libmisc file reference in the list below it
>  - the libmisc is also MIA
>
>
> in test-suite/Makefile.am:
> * I woud rather the STUBS= list was one file per line now if its going
> to be wrapped at all.
>
>
> in tools/Makefile.am
> * please use alphabetical order on cachemgr__CGIEXT__SOURCES changes
>  - that will even cut the patch by 1 line.
>
> +1. with the above
>
> Amos
> _______________________________________________
> squid-dev mailing list
> squid-dev@lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev
>



-- 
    Francesco

[Attachment #5 (text/html)]

<div dir="ltr">Merged with requested changes as r14244.</div><div \
class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 24, 2015 at 7:10 PM, \
Amos Jeffries <span dir="ltr">&lt;<a href="mailto:squid3@treenet.co.nz" \
target="_blank">squid3@treenet.co.nz</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><span class="">On 25/08/2015 3:36 a.m., Kinkie wrote:<br> \
&gt; Hi,<br> &gt;     part 4 (of 5) patches from the mempools-nozero branch: \
debug<br> &gt;<br>
&gt; This patch transforms Debug::OutStream into a MEMPROXY_CLASS instead of<br>
&gt; rolling its own new and delete operators. The biggest changes come from<br>
&gt; pulling in various Makefile.am files the necessary dependencies.<br>
&gt; I&#39;ve taken the chance to also rely more on Makefile variables in various<br>
&gt; file-copying recipes in order to simplify them a bit.<br>
&gt;<br>
&gt; Patch with big context attached.<br>
&gt;<br>
<br>
</span>in src/icmp/Makefile.am:<br>
* &quot;#libmem is needed for&quot;looks like it should be up on COPIED_SOURCE<br>
  - I see no libmem/libmisc file reference in the list below it<br>
  - the libmisc is also MIA<br>
<br>
<br>
in test-suite/Makefile.am:<br>
* I woud rather the STUBS= list was one file per line now if its going<br>
to be wrapped at all.<br>
<br>
<br>
in tools/Makefile.am<br>
* please use alphabetical order on cachemgr__CGIEXT__SOURCES changes<br>
  - that will even cut the patch by 1 line.<br>
<br>
+1. with the above<br>
<br>
Amos<br>
_______________________________________________<br>
squid-dev mailing list<br>
<a href="mailto:squid-dev@lists.squid-cache.org">squid-dev@lists.squid-cache.org</a><br>
 <a href="http://lists.squid-cache.org/listinfo/squid-dev" rel="noreferrer" \
target="_blank">http://lists.squid-cache.org/listinfo/squid-dev</a><br> \
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div \
class="gmail_signature">      Francesco</div> </div>


[Attachment #6 (text/plain)]

_______________________________________________
squid-dev mailing list
squid-dev@lists.squid-cache.org
http://lists.squid-cache.org/listinfo/squid-dev


[prev in list] [next in list] [prev in thread] [next in thread]