[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squid-dev
Subject:    Re: [PATCH] ConnStateData flexible transport support
From:       Alex Rousskov <rousskov () measurement-factory ! com>
Date:       2014-04-29 14:19:20
Message-ID: 535FB4E8.9040207 () measurement-factory ! com
[Download RAW message or body]

On 04/29/2014 06:03 AM, Amos Jeffries wrote:

> I'm fine with "transferProtocol" or just "protocol" (although that may
> get as common as "conn" has become). Whichever suits you.

Let's avoid "protocol" for the reasons you mentioned and use
"transferProtocol".


>>> This variable can
>>> be altered whenever necessary to cause an on-wire protocol change.

>> Altering the data member does not cause an on-wire protocol change in
>> the patched code AFAICT. Perhaps you meant that the data member should
>> always reflect the current wire protocol?


> Yes. However I was planning to use it to decode which Packer was
> allocated.

Sure, and the new data member is already used for other things. To the
extent possible, the description should focus on the meaning, not use,
especially when the use cases are diverse.


Thank you,

Alex.

[prev in list] [next in list] [prev in thread] [next in thread]