[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squid-dev
Subject:    Re: [PATCH 3/8] reconfiguration leaks: TcpAcceptor job
From:       Amos Jeffries <squid3 () treenet ! co ! nz>
Date:       2014-04-25 7:51:37
Message-ID: 535A1409.2000009 () treenet ! co ! nz
[Download RAW message or body]

On 25/04/2014 12:48 p.m., Alex Rousskov wrote:
> Do not leak TcpAcceptor job on reconfiguration
> by monitoring and reacting to the listening socket closure.
> 
> Every job that waits for Comm I/O must have a FD closure handler.
> Unfortunately, we currently cannot enforce that rule automatically.
> 
> Alex.
> 

The unused parameter 'io' on Comm::TcpAcceptor::handleClosure() should
be left without a name yes?

+1. Please apply ASAP. The above can be fixed on commit.

Amos

[prev in list] [next in list] [prev in thread] [next in thread]