[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squid-dev
Subject:    Re: [PATCH] Coverity defect 1135443
From:       Kinkie <gkinkie () gmail ! com>
Date:       2014-01-10 15:54:00
Message-ID: CA+Y8hcNVmQwJ52J4QHAVNkgVU2NHmXDENJWcwtB1Rihw87G5dg () mail ! gmail ! com
[Download RAW message or body]

done.

On Fri, Jan 10, 2014 at 12:53 AM, Amos Jeffries <squid3@treenet.co.nz> wrote:
> On 9/01/2014 9:57 p.m., Kinkie wrote:
>> Hi,
>>   Coverity detected a possible division by zero in
>> src/format/Format.cc line 500, on a Token->divisor.
>> The defect is a false positive as that value is correctly initialized,
>> but it could be a chance to document as a class invariant that that
>> value must not be zero, and initialize it to 1 in the default
>> constructor.
>> Attached patch does just that.
>>
>>
>>
>
> +1. Please apply.
>
> Amos



-- 
    /kinkie
[prev in list] [next in list] [prev in thread] [next in thread]