[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squid-dev
Subject:    Re: [PATCH] Better support compiler conditional flags on clang
From:       Amos Jeffries <squid3 () treenet ! co ! nz>
Date:       2013-06-22 4:17:24
Message-ID: 51C52554.9000700 () treenet ! co ! nz
[Download RAW message or body]

On 22/06/2013 2:50 a.m., Kinkie wrote:
> Hi,
>    different clang versions have different compiler flags.
> This patch tests if the -Wno-error=parentheses-equality and
> -Qunused-arguments flags are available before setting them at
> configure-time.

I'm scratching my head over this one a little.

You are testing for each flag independently.

I was of the understanding that the purpose of -Qunused-arguments was to 
enable the compiler to run with the -W flag. Which implies that the -W 
flag will fail its individual SQUID_CC_CHECK_ARGUMENT().
The if-statement causes either both to be used or neither. Was not the 
idea that the -W should be used, and -Q only necessary if -W failed?

Amos
[prev in list] [next in list] [prev in thread] [next in thread]