[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squid-dev
Subject:    Re: [PATCH] Define SIZEOF_OFF_T to fix overflow checks.
From:       Amos Jeffries <squid3 () treenet ! co ! nz>
Date:       2010-08-31 15:22:26
Message-ID: 4C7D1E32.5020806 () treenet ! co ! nz
[Download RAW message or body]

Alex Rousskov wrote:
> Define SIZEOF_OFF_T to fix overflow checks.
> 
> Overflow checks were broken because 'SIZEOF_OFF_T <= 4' was always true 
> because SIZEOF_OFF_T was not defined and, hence, treated as zero.
> 
> Co-Advisor test cases:
> 
> test_case/rfc2616/noXform-fwd-Content-Range-simple-2147483645-2147483646-2147483647-withCc-toClt 
> 
> 
> test_case/rfc2616/noXform-fwd-Content-Range-simple-2147483645-2147483646-*-withCc-toClt 
> 
> 

Yeesh. +2.

Amos
-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.7
   Beta testers wanted for 3.2.0.1
[prev in list] [next in list] [prev in thread] [next in thread]