[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squid-dev
Subject:    Re: [PATCH] HttpMsgPointer
From:       Amos Jeffries <squid3 () treenet ! co ! nz>
Date:       2010-08-30 23:20:27
Message-ID: a90226f07cc61d190c025b38f3126e03 () mail ! treenet ! co ! nz
[Download RAW message or body]

On Mon, 30 Aug 2010 17:10:33 -0600, Alex Rousskov
<rousskov@measurement-factory.com> wrote:
> Added safe HttpMsg pointer wrapper that locks and unlocks the message.
> 
> This class will not be needed if we switch to refcounting HttpMsg. 
> Meanwhile, it allows to pass message pointers in AsyncCalls and avoid 
> auto_ptr<> in exception-sensitive code.
> 
> ---------
> 
> I am considering making the HttpMsgPointerT::lock() and unlock() methods

> protected because it would be difficult for the caller to use them 
> correctly and because it is probably not necessary for the caller to use

> them at all.

Indeed. The closer to RefCount these can behave the better for that future
transition.

Amos
[prev in list] [next in list] [prev in thread] [next in thread]