[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squid-dev
Subject:    Re: [PATCH] port of http_access2 from 2.6
From:       Alex Rousskov <rousskov () measurement-factory ! com>
Date:       2010-01-22 22:58:07
Message-ID: 4B5A2D7F.4010205 () measurement-factory ! com
[Download RAW message or body]

On 01/20/2010 04:02 PM, Amos Jeffries wrote:
> On Wed, 20 Jan 2010 09:58:01 -0700, Alex Rousskov
> <rousskov@measurement-factory.com> wrote:

>> Should the documentation mention that redirects are performed before the
>> second access check?
> 
> I think so. That being one of the two differences between this and
> http_access.
> Or did you mean the cf.data.pre changes were not descriptive/clear enough?

It is the latter. I think the option documentation blob in cf.data.pre
should mention the redirection in addition to adaptation.

>> I am not a big fan of fooN names. Is using something more specific like
>> post_adaptation_access be better long-term?
> 
> Does adapted_http_access seem clearer?
> Being that it's a variant of http_access, always done and only useful when
> checking for adapted things.

adapted_http_access sounds good to me.

Thank you,

Alex.
[prev in list] [next in list] [prev in thread] [next in thread]