[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squid-cvs
Subject:    Re: /bzr/squid3/trunk/ r13384: Bug 1961: pt1: URL handling redesign
From:       Tsantilas Christos <chtsanti () users ! sourceforge ! net>
Date:       2014-04-27 17:35:31
Message-ID: 535D3FE3.5050203 () users ! sourceforge ! net
[Download RAW message or body]

Unfortunately this is not build with ecap.

The ecap uses the HttpMsg::protocol, to describe protocol for both
requests and responses.
Looks that HttpReply::protocol was never set (Am I loosing something?).


Is it a bad idea to replace HttpMsg::protocol with a virtual method,
which return HttpRequest::url.getScheme() for HttpRequest objects, and
HttpReply::sline.protocol for HttpReply objects?




On 04/27/2014 10:59 AM, Amos Jeffries wrote:
> ------------------------------------------------------------
> revno: 13384
> fixes bug(s): http://bugs.squid-cache.org/show_bug.cgi?id=1961
> committer: Amos Jeffries <squid3@treenet.co.nz>
> branch nick: trunk
> timestamp: Sun 2014-04-27 00:59:17 -0700
> message:
>   Bug 1961: pt1: URL handling redesign
>   
>   Replace the HttpMsg::protocol member (only used by HttpRequest) with a
>   class URL member HttpRequest::url. To do this we adjust the class URL
>   scheme_ member to be mutable via the makeScheme() setter, and add a
>   clear() method to reset its internal state. These are necessary for
>   HttpRequest init() and initHTTP() mechanisms, but fiddling with the
>   scheme should be avoided as much as possible.
>   
>   Remove the hack of forcing internal requests to http:// for processing
>   and cache lookup, then to internal:// for FwdState. Instead use the
>   available flags.internal for requests identified to be served by this proxy.
>   
>   Drop the non-standard and now meaningless "internal://" scheme.
>   
>   Add debugging to display what internal indicators are detected and when
>   the internal*() server and CacheManager are used by FwdState.
>   
>   Also document HttpMsg::http_ver which is a copy of the HTTP-Version
>   field in the "on-wire" message syntax. It is unrelated to the socket
>   transport protocol and the URL scheme protocol.
> modified:
>   src/FwdState.cc
>   src/HttpMsg.cc
>   src/HttpMsg.h
>   src/HttpReply.cc
>   src/HttpRequest.cc
>   src/HttpRequest.h
>   src/URL.h
>   src/acl/Protocol.cc
>   src/adaptation/ecap/Host.cc
>   src/adaptation/ecap/MessageRep.cc
>   src/anyp/ProtocolType.h
>   src/carp.cc
>   src/cf.data.pre
>   src/client_side.cc
>   src/client_side_reply.cc
>   src/client_side_request.cc
>   src/errorpage.cc
>   src/external_acl.cc
>   src/ftp.cc
>   src/http.cc
>   src/internal.cc
>   src/peer_select.cc
>   src/tests/testHttpRequest.cc
>   src/url.cc
> 

[prev in list] [next in list] [prev in thread] [next in thread]