[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squeak-dev
Subject:    Re: [squeak-dev] IntegerTest>>#testExactSqrt broken on 32bit trunk
From:       Fabio Niephaus <lists () fniephaus ! com>
Date:       2019-05-23 21:22:07
Message-ID: CADfnKi5w3mnKU8wfea0s0PS7WzX3DP7-Pe8SAmfXz=7JTYPiNg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/related)]

[Attachment #4 (multipart/alternative)]


Perfect...thanks for the swift fix, Nicolas!
Our CI pipeline is now fully unblocked, here are the new trunk builds:
http://files.squeak.org/5.3alpha/Squeak5.3alpha-18594-64bit/
http://files.squeak.org/5.3alpha/Squeak5.3alpha-18594-32bit/

Fabio


On Thu, 23 May 2019 at 9:26 pm, Nicolas Cellier <
nicolas.cellier.aka.nice@gmail.com> wrote:

> done
>
> Le jeu. 23 mai 2019 =C3=A0 21:00, Nicolas Cellier <
> nicolas.cellier.aka.nice@gmail.com> a =C3=A9crit :
>
>> Ah, it's an infinite loop on 32bits, I'll commit a patch soon.
>>
>> Le jeu. 23 mai 2019 =C3=A0 18:40, Nicolas Cellier <
>> nicolas.cellier.aka.nice@gmail.com> a =C3=A9crit :
>>
>>> Hi Fabio,
>>> It seems to just be a timeOut.
>>> I'll have a look.
>>>
>>> Le jeu. 23 mai 2019 =C3=A0 17:05, Fabio Niephaus <lists@fniephaus.com> =
a
>>> =C3=A9crit :
>>>
>>>> Hi all,
>>>>
>>>> It looks like there's a large integer-related problem in 32bit trunk
>>>> (see screenshot and [1]). I'm assuming this was introduced with the re=
cent
>>>> changes Nicolas incorporated. Maybe someone could have a look? For
>>>> reproducing, download the last 32bit trunk image [2], update it, and r=
un
>>>> IntegerTest>>#testExactSqrt.
>>>>
>>>> Since 64bit works, we finally have a new 64bit trunk build (see [3]).
>>>>
>>>> Cheers,
>>>> Fabio
>>>>
>>>> [1]
>>>> https://travis-ci.org/squeak-smalltalk/squeak-app/jobs/536301595#L2512
>>>> [2] http://files.squeak.org/5.3alpha/Squeak5.3alpha-18498-32bit/
>>>> [3] http://files.squeak.org/5.3alpha/Squeak5.3alpha-18592-64bit/
>>>>
>>>> [image: image.png]
>>>>
>>>>
>

[Attachment #7 (text/html)]

<div><div dir="auto">Perfect...thanks for the swift fix, Nicolas!</div></div><div \
dir="auto">Our CI pipeline is now fully unblocked, here are the new trunk \
builds:</div><div dir="auto"><div><a \
href="http://files.squeak.org/5.3alpha/Squeak5.3alpha-18594-64bit/">http://files.squeak.org/5.3alpha/Squeak5.3alpha-18594-64bit/</a></div><div><a \
href="http://files.squeak.org/5.3alpha/Squeak5.3alpha-18594-32bit/">http://files.squeak.org/5.3alpha/Squeak5.3alpha-18594-32bit/</a></div></div><div \
dir="auto"><br></div><div dir="auto">Fabio</div><div \
dir="auto"><br></div><div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Thu, 23 May 2019 at 9:26 pm, Nicolas Cellier &lt;<a \
href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div \
dir="ltr">done<br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">Le  jeu. 23 mai 2019 Ã   21:00, Nicolas Cellier &lt;<a \
href="mailto:nicolas.cellier.aka.nice@gmail.com" \
target="_blank">nicolas.cellier.aka.nice@gmail.com</a>&gt; a écrit  \
:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Ah, \
it&#39;s an infinite loop on 32bits, I&#39;ll commit a patch soon.<br></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">Le  jeu. 23 mai 2019 Ã   18:40, \
Nicolas Cellier &lt;<a href="mailto:nicolas.cellier.aka.nice@gmail.com" \
target="_blank">nicolas.cellier.aka.nice@gmail.com</a>&gt; a écrit  \
:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi \
Fabio,</div><div>It seems to just be a timeOut. <div>I&#39;ll have a look.</div>

</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le  jeu. \
23 mai 2019 Ã   17:05, Fabio Niephaus &lt;<a href="mailto:lists@fniephaus.com" \
target="_blank">lists@fniephaus.com</a>&gt; a écrit  :<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi \
all,</div><div><br></div><div>It looks like there&#39;s a large integer-related \
problem in 32bit trunk (see screenshot and [1]). I&#39;m assuming this was introduced \
with the recent changes Nicolas incorporated. Maybe someone could have a look? For \
reproducing, download the last 32bit trunk image [2], update it, and run \
IntegerTest&gt;&gt;#testExactSqrt.</div><div><br></div><div>Since 64bit works, we \
finally have a new 64bit trunk build (see \
[3]).</div><div><br></div><div>Cheers,</div><div>Fabio</div><div><br></div><div>[1]  \
<a href="https://travis-ci.org/squeak-smalltalk/squeak-app/jobs/536301595#L2512" \
target="_blank">https://travis-ci.org/squeak-smalltalk/squeak-app/jobs/536301595#L2512</a></div><div>[2] \
<a href="http://files.squeak.org/5.3alpha/Squeak5.3alpha-18498-32bit/" \
target="_blank">http://files.squeak.org/5.3alpha/Squeak5.3alpha-18498-32bit/</a></div><div>[3] \
<a href="http://files.squeak.org/5.3alpha/Squeak5.3alpha-18592-64bit/" \
target="_blank">http://files.squeak.org/5.3alpha/Squeak5.3alpha-18592-64bit/</a></div><div><br></div><div><img \
src="cid:ii_jw0s8hfi0" alt="image.png" \
style="width:529px;max-width:100%"><br></div></div> <br>
</blockquote></div>
</blockquote></div>
</blockquote></div>
<br>
</blockquote></div></div>


["image.png" (image/png)]
[Attachment #9 (text/plain)]




[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic